Epsilon removing analytics#13107
Closed
AaronColbyPrice wants to merge 6 commits into
Closed
Conversation
…13101) Co-authored-by: Dmitry Moskalyov <dmoskalyov@iponweb.net>
* Update limelightDigitalBidAdapter.js * Update limelightDigitalBidAdapter.js * Update user sync headers --------- Co-authored-by: apykhteyev <alex@project-limelight.com>
* Added bidglass adapter + test * PR Review Updates: - Added formal params to getUserSyncs function definition - getUserSyncs now always returns an array - Improved unit test coverage * PR Review Updates: - Removed unused methods: getUserSyncs, onTimeout, onBidWon, onSetTargeting - Removed getUserSyncs unit test - Removed "dead code" - Removed some unnecessary comments - Fixed usage of parseInt * Bid Glass Bid Adapter: pass options in bid request * Merge externally set targeting params * Updates to address gulp errors * Get `bidglass` reference from window * Add support for meta.advertiserDomains * Remove numeric requirement for params.adUnitId * Add GDPR/GPP consent data to bid requests * Replace `&replaceme` in server-returned `ad` HTML with encoded GDPR/GPP params from bid request * Bid Glass Adapter: Update tests * Fix interpretResponse: based on examining other adapters it seems the 2nd param is actually a `ServerRequest` object * Fix test (add serverRequest param to spec.interpretResponse()) * Fix linting
* MAINTAG-386 Citynews (76d8a3332520158) - Prebid Version Update Issue * MAINTAG-323 Native & Legacy Native | Gestione della retrocompatibilità * Add if statement on native tests for ortb format * Extended tests to native legacy version * Make tests more general * Fix native tests and priceFloor handling for native mediaType --------- Co-authored-by: Federico Liccione <f.liccione@onetag.com>
Contributor
Author
|
@patmmccann did I do it right? (thanks for the fast comment on the correct way to do it) |
Collaborator
|
it seems like you did not base on prebid 10, but you pr'd to it, so anything where master is ahead of 10 is included in your changes |
Collaborator
|
i did it at #13111 |
Contributor
Author
Thanks Pat, sorry you had to pick up my slack! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Removing epsilon bid analytics adapter
Other information
Documentation update: prebid/prebid.github.io#6039