-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Acuity Bid Adapter : handle publisher id #13508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
a23e8f7
add prebid.js adapter
AcuityAdsIntegrations d554bd8
fix conflicts
AcuityAdsIntegrations 05f5982
changes
AcuityAdsIntegrations c2e64f1
changes
AcuityAdsIntegrations f1b7c90
changes
AcuityAdsIntegrations afe8d2a
changes
AcuityAdsIntegrations 32788c1
Merge remote-tracking branch 'prebid/master'
AcuityAdsIntegrations a462305
fix downolad
AcuityAdsIntegrations 1a4d04b
Merge remote-tracking branch 'prebid/master'
AcuityAdsIntegrations fc3fddd
add gpp
AcuityAdsIntegrations 8a5c619
Merge remote-tracking branch 'prebid/master'
AcuityAdsIntegrations 30cd778
add gvlid
AcuityAdsIntegrations bd6953e
Merge remote-tracking branch 'prebid/master'
AcuityAdsIntegrations 27dbb28
Merge remote-tracking branch 'prebid/master'
AcuityAdsIntegrations e29b6f5
add endpointId param
AcuityAdsIntegrations 0a42956
add publisherId to placement
47a0cd0
Merge pull request #1 from AcuityAdsIntegrations/acuity_update
AcuityAdsIntegrations 657d266
Merge branch 'master' into master
AcuityAdsIntegrations b7d84db
fix import issue
AcuityAdsIntegrations 35d54c8
Merge remote-tracking branch 'origin/master'
AcuityAdsIntegrations File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,35 @@ | ||
| import { registerBidder } from '../src/adapters/bidderFactory.js'; | ||
| import { BANNER, NATIVE, VIDEO } from '../src/mediaTypes.js'; | ||
| import { isBidRequestValid, buildRequests, interpretResponse, getUserSyncs } from '../libraries/teqblazeUtils/bidderUtils.js'; | ||
| import { | ||
| isBidRequestValid, | ||
| buildRequestsBase, | ||
| interpretResponse, | ||
| getUserSyncs, | ||
| buildPlacementProcessingFunction | ||
| } from '../libraries/teqblazeUtils/bidderUtils.js'; | ||
|
|
||
| const BIDDER_CODE = 'acuityads'; | ||
| const GVLID = 231; | ||
| const AD_URL = 'https://prebid.admanmedia.com/pbjs'; | ||
| const SYNC_URL = 'https://cs.admanmedia.com'; | ||
|
|
||
| const addCustomFieldsToPlacement = (bid, bidderRequest, placement) => { | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why not convert to typescript? |
||
| placement.publisherId = bid.params.publisherId || ''; | ||
| }; | ||
|
|
||
| const placementProcessingFunction = buildPlacementProcessingFunction({ addCustomFieldsToPlacement }); | ||
|
|
||
| const buildRequests = (validBidRequests = [], bidderRequest = {}) => { | ||
| return buildRequestsBase({ adUrl: AD_URL, validBidRequests, bidderRequest, placementProcessingFunction }); | ||
| }; | ||
|
|
||
| export const spec = { | ||
| code: BIDDER_CODE, | ||
| gvlid: GVLID, | ||
| supportedMediaTypes: [BANNER, VIDEO, NATIVE], | ||
|
|
||
| isBidRequestValid: isBidRequestValid(), | ||
| buildRequests: buildRequests(AD_URL), | ||
| buildRequests, | ||
| interpretResponse, | ||
| getUserSyncs: getUserSyncs(SYNC_URL) | ||
| }; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.