Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions modules/acuityadsBidAdapter.js
Original file line number Diff line number Diff line change
@@ -1,19 +1,35 @@
import { registerBidder } from '../src/adapters/bidderFactory.js';
import { BANNER, NATIVE, VIDEO } from '../src/mediaTypes.js';
import { isBidRequestValid, buildRequests, interpretResponse, getUserSyncs } from '../libraries/teqblazeUtils/bidderUtils.js';
import {
isBidRequestValid,
buildRequestsBase,
interpretResponse,
getUserSyncs,
buildPlacementProcessingFunction
} from '../libraries/teqblazeUtils/bidderUtils.js';
Comment thread
patmmccann marked this conversation as resolved.

const BIDDER_CODE = 'acuityads';
const GVLID = 231;
const AD_URL = 'https://prebid.admanmedia.com/pbjs';
const SYNC_URL = 'https://cs.admanmedia.com';

const addCustomFieldsToPlacement = (bid, bidderRequest, placement) => {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not convert to typescript?

placement.publisherId = bid.params.publisherId || '';
};

const placementProcessingFunction = buildPlacementProcessingFunction({ addCustomFieldsToPlacement });

const buildRequests = (validBidRequests = [], bidderRequest = {}) => {
return buildRequestsBase({ adUrl: AD_URL, validBidRequests, bidderRequest, placementProcessingFunction });
};

export const spec = {
code: BIDDER_CODE,
gvlid: GVLID,
supportedMediaTypes: [BANNER, VIDEO, NATIVE],

isBidRequestValid: isBidRequestValid(),
buildRequests: buildRequests(AD_URL),
buildRequests,
interpretResponse,
getUserSyncs: getUserSyncs(SYNC_URL)
};
Expand Down
9 changes: 7 additions & 2 deletions modules/acuityadsBidAdapter.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ AcuityAds bid adapter supports Banner, Video (instream and outstream) and Native
bidder: 'acuityads',
params: {
placementId: 'testBanner',
}
endpointId: 'testBanner',
publisherId: 'testBanner',
}
]
},
Expand All @@ -46,6 +47,8 @@ AcuityAds bid adapter supports Banner, Video (instream and outstream) and Native
bidder: 'acuityads',
params: {
placementId: 'testVideo',
endpointId: 'testVideo',
publisherId: 'testVideo',
}
}
]
Expand All @@ -71,9 +74,11 @@ AcuityAds bid adapter supports Banner, Video (instream and outstream) and Native
bidder: 'acuityads',
params: {
placementId: 'testNative',
endpointId: 'testNative',
publisherId: 'testNative',
}
}
]
}
];
```
```
50 changes: 50 additions & 0 deletions test/spec/modules/acuityadsBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,56 @@ describe('AcuityAdsBidAdapter', function () {
expect(placement.bidfloor).to.exist.and.to.equal(0);
expect(placement.type).to.exist.and.to.equal('publisher');
expect(placement.eids).to.exist.and.to.be.deep.equal(userIdAsEids);
expect(placement.publisherId).to.exist.and.to.be.a('string');

if (placement.adFormat === BANNER) {
expect(placement.sizes).to.be.an('array');
}
switch (placement.adFormat) {
case BANNER:
expect(placement.sizes).to.be.an('array');
break;
case VIDEO:
expect(placement.playerSize).to.be.an('array');
expect(placement.minduration).to.be.an('number');
expect(placement.maxduration).to.be.an('number');
break;
case NATIVE:
expect(placement.native).to.be.an('object');
break;
}
}
});

it('Returns valid endpoints', function () {
const bids = [
{
bidId: getUniqueIdentifierStr(),
bidder: bidder,
mediaTypes: {
[BANNER]: {
sizes: [[300, 250]]
}
},
params: {
endpointId: 'testBanner',
},
userIdAsEids
}
];

let serverRequest = spec.buildRequests(bids, bidderRequest);

const { placements } = serverRequest.data;
for (let i = 0, len = placements.length; i < len; i++) {
const placement = placements[i];
expect(placement.endpointId).to.be.oneOf(['testBanner', 'testVideo', 'testNative']);
expect(placement.adFormat).to.be.oneOf([BANNER, VIDEO, NATIVE]);
expect(placement.bidId).to.be.a('string');
expect(placement.schain).to.be.an('object');
expect(placement.bidfloor).to.exist.and.to.equal(0);
expect(placement.type).to.exist.and.to.equal('network');
expect(placement.eids).to.exist.and.to.be.deep.equal(userIdAsEids);

if (placement.adFormat === BANNER) {
expect(placement.sizes).to.be.an('array');
Expand Down