programmaticx Bid Adapter: change endpoint#13549
Conversation
|
I know most of '../libraries/vidazooUtils/bidderUtils.js' is covered (https://coveralls.io/builds/74542659/source?filename=libraries%2FvidazooUtils%2FbidderUtils.js) but we do need some tests, at least for the correct bidding and sync endpoints getting called |
patmmccann
changed the title
| } from '../libraries/vidazooUtils/bidderUtils.js'; | ||
|
|
||
| const DEFAULT_SUB_DOMAIN = 'exchange'; | ||
| const BIDDER_CODE = 'programmaticx'; |
There was a problem hiding this comment.
isnt this bidder code already in use?
|
Why don't you just change the old adapter instead of making a new one |
It is not our code in the old folder. No idea if it is in use |
|
Ask your client if they want to maintain both simultaneously in the same prebid version |
|
@patmmccann |
|
replacing the one they have does this; as publishers upgrade to 10.x, this will occur over a year or two. |
Hi @patmmccann . Unfortunately this is outside our domain. We were asked by the customer to not change that so that is a discussion you should have with them. There are already some cos with multiple adapters, so the precedence is there. We can that discussion with the demand partner offline, but I'd appreciate if you could unblock us in the meanwhile as this won't be something that is solved at a moments notice. |
well perhaps you could ask them to engage |
|
ok, cleared things up and it was my mistake. It's a different bidder and product under the same entity (a new business line - unrelated to the previous bidder). We'll update the adapter name to the new product name to reflect this difference. Apologies. |
anna-y-perion
changed the title
anna-y-perion
changed the title
anna-y-perion
changed the title
anna-y-perion
changed the title
|
Hi @patmmccann |
|
Hi @patmmccann , @dgirardi , @ChrisHuie [FYI @bgoldin-vidazoo ] |
|
@bgoldin-vidazoo mentioned a plan to change the brand name here but instead you just abbreviated it instead of adding a token at the end as you had initially. What's going on here? Why not just fix the existing adapter? |
|
Hi @patmmccann , thanks again for your attention here. To clarify: this adapter is operated by a different white-label provider and is still actively in use. That’s why we were asked to create a separate adapter rather than modify the existing one. We understand the concern around keeping things clean and maintainable. To support that:
I'm not aware of a specific policy against having multiple adapters under the same corporate entity, so if there’s a concrete action you’d like us to take in order to move this forward, please let us know. Otherwise, it feels like we’re being blocked without a clear path to resolution, and we’d really appreciate your help in unblocking this. Thanks, Boris |
|
Prebid's module rules mention efficiency as our first core value. I am not sure why the progx team themselves have been impossible to summon, but we're not moving forward here without them. I'm responsible for making sure prebid is a good product for publishers, and having a giant mess of adapters where no one is sure which is the real adapter for some entity is not a good experience for the publisher |
|
@patmmccann ok, after additional discussions with px we'll replace their existing adapter. thank you |
| { | ||
| bidder: 'programmaticX', | ||
| params: { | ||
| placementId: 'testBanner', |
There was a problem hiding this comment.
your existing publisher base will be setting this parameter. You should try and get it to your backend somehow :) you may want to handle it server side in some useful way (reporting, setting gpid, qa, not sure)
There was a problem hiding this comment.
added support.
Thank you
patmmccann
changed the title
|
@bgoldin-vidazoo this looks good, but please consider #13549 (comment) as a follow up |
|
Hey @patmmccann could you check #13686 ? |
* adding programmaticxOrtbBidAdapter * adding programmaticxOrtbBidAdapter tests * reviewing TEST_ID_SYSTEMS * adding required test; fixing code * adding minor changes * fix wrong bidder code in tests * change adapter * change adapter * replacing old programmaticX adapter with new code * fix: support for placementId field --------- Co-authored-by: saar120 <saar120@gmail.com>
5 participants
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information