Skip to content

programmaticXBidAdapter: fix tests #13688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patmmccann merged 2 commits into from
Jul 29, 2025
Merged

programmaticXBidAdapter: fix tests #13688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c302ebe
programmaticXBidAdapter: fix tests
dgirardi Jul 29, 2025
6fbeb86
Update adplusAnalyticsAdapter_spec.js
patmmccann Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
330 changes: 165 additions & 165 deletions test/spec/modules/adplusAnalyticsAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,169 +8,169 @@ import sinon from 'sinon';
let events = require('src/events');

describe('AdPlus analytics adapter', function () {
let sandbox, clock;

beforeEach(function () {
sandbox = sinon.createSandbox();
sandbox.spy(console, 'log');

clock = sandbox.useFakeTimers();
sandbox.stub(events, 'getEvents').returns([]);
adapterManager.enableAnalytics({ provider: 'adplus' });
});

afterEach(function () {
sandbox.restore();
adplusAnalyticsAdapter.reset();
});

const auctionId = 'test-auction-123';

const bidsReceived = [
{
bidderCode: 'adplus',
auctionId,
adUnitCode: 'adunit-1',
cpm: 5,
currency: 'USD',
size: '300x250',
width: 300,
height: 250,
creativeId: 'crea-1',
timeToRespond: 120,
netRevenue: true,
dealId: null
},
{
bidderCode: 'adplus',
auctionId,
adUnitCode: 'adunit-2',
cpm: 7,
currency: 'USD',
size: '728x90',
width: 728,
height: 90,
creativeId: 'crea-2',
timeToRespond: 110,
netRevenue: true,
dealId: 'deal123'
}
];

const bidWon1 = {
auctionId,
adUnitCode: 'adunit-1',
bidderCode: 'adplus',
cpm: 5,
currency: 'USD',
size: '300x250',
width: 300,
height: 250,
creativeId: 'crea-1',
timeToRespond: 120,
netRevenue: true,
dealId: null
};

const bidWon2 = {
auctionId,
adUnitCode: 'adunit-2',
bidderCode: 'adplus',
cpm: 7,
currency: 'USD',
size: '728x90',
width: 728,
height: 90,
creativeId: 'crea-2',
timeToRespond: 110,
netRevenue: true,
dealId: 'deal123'
};

it('should store bids on AUCTION_END and not send immediately', function () {
events.emit(EVENTS.AUCTION_END, {
auctionId,
bidsReceived
});

expect(server.requests.length).to.equal(0);

const storedData = adplusAnalyticsAdapter.auctionBids[auctionId];
expect(storedData).to.exist;
expect(Object.keys(storedData)).to.have.length(2);
expect(storedData['adunit-1'][0]).to.include({
auctionId,
adUnitCode: 'adunit-1',
bidder: 'adplus',
cpm: 5,
currency: 'USD'
});
});

it('should batch BID_WON events and send after delay with retries', function (done) {
// First, send AUCTION_END to prepare data
events.emit(EVENTS.AUCTION_END, { auctionId, bidsReceived });

// Emit first BID_WON - should send immediately
events.emit(EVENTS.BID_WON, bidWon1);

clock.tick(0);
expect(server.requests.length).to.equal(1);

// Fail first request, triggers retry after 200ms
server.requests[0].respond(500, {}, 'Internal Server Error');
clock.tick(200);

expect(server.requests.length).to.equal(2);

// Fail second (retry) request, triggers next retry
server.requests[1].respond(500, {}, 'Internal Server Error');
clock.tick(200);

expect(server.requests.length).to.equal(3);

// Succeed on third retry
server.requests[2].respond(200, { 'Content-Type': 'application/json' }, JSON.stringify({ status: 'ok' }));

// Now emit second BID_WON - queue is empty, should send immediately
events.emit(EVENTS.BID_WON, bidWon2);

// Should wait 200ms after emit.
expect(server.requests.length).to.equal(3);

// Sends the second BID_WON data after 200ms
clock.tick(200);
expect(server.requests.length).to.equal(4);

// Succeed second BID_WON send
server.requests[3].respond(200, { 'Content-Type': 'application/json' }, JSON.stringify({ status: 'ok' }));

// Validate payloads
const payload1 = JSON.parse(server.requests[0].requestBody);
const payload2 = JSON.parse(server.requests[3].requestBody);

expect(payload1.winningBid).to.include({
auctionId,
adUnitCode: 'adunit-1',
bidder: 'adplus',
cpm: 5,
});

expect(payload2.winningBid).to.include({
auctionId,
adUnitCode: 'adunit-2',
bidder: 'adplus',
cpm: 7,
});

done();
});

it('should skip BID_WON if no auction data available', function () {
// Emit BID_WON without AUCTION_END first
expect(() => events.emit(EVENTS.BID_WON, bidWon1)).to.not.throw();

// No ajax call since no auctionData
expect(server.requests.length).to.equal(0);
});
let sandbox, clock;

beforeEach(function () {
sandbox = sinon.createSandbox();
sandbox.spy(console, 'log');

clock = sandbox.useFakeTimers();
sandbox.stub(events, 'getEvents').returns([]);
adapterManager.enableAnalytics({ provider: 'adplus' });
});

afterEach(function () {
sandbox.restore();
adplusAnalyticsAdapter.reset();
});

const auctionId = 'test-auction-123';

const bidsReceived = [
{
bidderCode: 'adplus',
auctionId,
adUnitCode: 'adunit-1',
cpm: 5,
currency: 'USD',
size: '300x250',
width: 300,
height: 250,
creativeId: 'crea-1',
timeToRespond: 120,
netRevenue: true,
dealId: null
},
{
bidderCode: 'adplus',
auctionId,
adUnitCode: 'adunit-2',
cpm: 7,
currency: 'USD',
size: '728x90',
width: 728,
height: 90,
creativeId: 'crea-2',
timeToRespond: 110,
netRevenue: true,
dealId: 'deal123'
}
];

const bidWon1 = {
auctionId,
adUnitCode: 'adunit-1',
bidderCode: 'adplus',
cpm: 5,
currency: 'USD',
size: '300x250',
width: 300,
height: 250,
creativeId: 'crea-1',
timeToRespond: 120,
netRevenue: true,
dealId: null
};

const bidWon2 = {
auctionId,
adUnitCode: 'adunit-2',
bidderCode: 'adplus',
cpm: 7,
currency: 'USD',
size: '728x90',
width: 728,
height: 90,
creativeId: 'crea-2',
timeToRespond: 110,
netRevenue: true,
dealId: 'deal123'
};

it('should store bids on AUCTION_END and not send immediately', function () {
events.emit(EVENTS.AUCTION_END, {
auctionId,
bidsReceived
});

expect(server.requests.length).to.equal(0);

const storedData = adplusAnalyticsAdapter.auctionBids[auctionId];
expect(storedData).to.exist;
expect(Object.keys(storedData)).to.have.length(2);
expect(storedData['adunit-1'][0]).to.include({
auctionId,
adUnitCode: 'adunit-1',
bidder: 'adplus',
cpm: 5,
currency: 'USD'
});
});

it('should batch BID_WON events and send after delay with retries', function (done) {
// First, send AUCTION_END to prepare data
events.emit(EVENTS.AUCTION_END, { auctionId, bidsReceived });

// Emit first BID_WON - should send immediately
events.emit(EVENTS.BID_WON, bidWon1);

clock.tick(0);
expect(server.requests.length).to.equal(1);

// Fail first request, triggers retry after 200ms
server.requests[0].respond(500, {}, 'Internal Server Error');
clock.tick(200);

expect(server.requests.length).to.equal(2);

// Fail second (retry) request, triggers next retry
server.requests[1].respond(500, {}, 'Internal Server Error');
clock.tick(200);

expect(server.requests.length).to.equal(3);

// Succeed on third retry
server.requests[2].respond(200, { 'Content-Type': 'application/json' }, JSON.stringify({ status: 'ok' }));

// Now emit second BID_WON - queue is empty, should send immediately
events.emit(EVENTS.BID_WON, bidWon2);

// Should wait 200ms after emit.
expect(server.requests.length).to.equal(3);

// Sends the second BID_WON data after 200ms
clock.tick(200);
expect(server.requests.length).to.equal(4);

// Succeed second BID_WON send
server.requests[3].respond(200, { 'Content-Type': 'application/json' }, JSON.stringify({ status: 'ok' }));

// Validate payloads
const payload1 = JSON.parse(server.requests[0].requestBody);
const payload2 = JSON.parse(server.requests[3].requestBody);

expect(payload1.winningBid).to.include({
auctionId,
adUnitCode: 'adunit-1',
bidder: 'adplus',
cpm: 5,
});

expect(payload2.winningBid).to.include({
auctionId,
adUnitCode: 'adunit-2',
bidder: 'adplus',
cpm: 7,
});

done();
});

it('should skip BID_WON if no auction data available', function () {
// Emit BID_WON without AUCTION_END first
expect(() => events.emit(EVENTS.BID_WON, bidWon1)).to.not.throw();

// No ajax call since no auctionData
expect(server.requests.length).to.equal(0);
});
});
13 changes: 7 additions & 6 deletions test/spec/modules/programmaticXBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import {
tryParseJSON,
getUniqueDealId,
} from '../../../libraries/vidazooUtils/bidderUtils.js';
import {getGlobal} from '../../../src/prebidGlobal.js';

export const TEST_ID_SYSTEMS = ['criteoId', 'id5id', 'netId', 'tdid', 'pubProvidedId', 'intentIqId', 'liveIntentId'];

Expand Down Expand Up @@ -273,7 +274,7 @@ describe('programmaticXBidAdapter', function () {
describe('build requests', function () {
let sandbox;
before(function () {
$$PREBID_GLOBAL$$.bidderSettings = {
getGlobal().bidderSettings = {
programmaticX: {
storageAllowed: true
}
Expand Down Expand Up @@ -435,7 +436,7 @@ describe('programmaticXBidAdapter', function () {
});

after(function () {
$$PREBID_GLOBAL$$.bidderSettings = {};
getGlobal().bidderSettings = {};
sandbox.restore();
});
});
Expand Down Expand Up @@ -623,14 +624,14 @@ describe('programmaticXBidAdapter', function () {

describe('unique deal id', function () {
before(function () {
$$PREBID_GLOBAL$$.bidderSettings = {
getGlobal().bidderSettings = {
programmaticX: {
storageAllowed: true
}
};
});
after(function () {
$$PREBID_GLOBAL$$.bidderSettings = {};
getGlobal().bidderSettings = {};
});
const key = 'myKey';
let uniqueDealId;
Expand Down Expand Up @@ -658,14 +659,14 @@ describe('programmaticXBidAdapter', function () {

describe('storage utils', function () {
before(function () {
$$PREBID_GLOBAL$$.bidderSettings = {
getGlobal().bidderSettings = {
programmaticX: {
storageAllowed: true
}
};
});
after(function () {
$$PREBID_GLOBAL$$.bidderSettings = {};
getGlobal().bidderSettings = {};
});
it('should get value from storage with create param', function () {
const now = Date.now();
Expand Down
Loading