Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions modules/nextMillenniumBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import {registerBidder} from '../src/adapters/bidderFactory.js';
import {getRefererInfo} from '../src/refererDetection.js';
import { getViewportSize } from '../libraries/viewport/viewport.js';

const NM_VERSION = '4.3.0';
const NM_VERSION = '4.4.0';
const PBJS_VERSION = 'v$prebid.version$';
const GVLID = 1060;
const BIDDER_CODE = 'nextMillennium';
Expand Down Expand Up @@ -265,18 +265,22 @@ export const spec = {
},
};

function getExtNextMilImp(bid) {
export function getExtNextMilImp(bid) {
if (typeof window?.nmmRefreshCounts[bid.adUnitCode] === 'number') ++window.nmmRefreshCounts[bid.adUnitCode];
const {adSlots, allowedAds} = bid.params
const nextMilImp = {
impId: bid.bidId,
nextMillennium: {
nm_version: NM_VERSION,
pbjs_version: PBJS_VERSION,
refresh_count: window?.nmmRefreshCounts[bid.adUnitCode] || 0,
scrollTop: window.pageYOffset || getWinDimensions().document.documentElement.scrollTop,
refresh_count: window?.nmmRefreshCounts?.[bid.adUnitCode] || 0,
scrollTop: window?.pageYOffset || getWinDimensions()?.document?.documentElement?.scrollTop,
},
};

if (Array.isArray(adSlots)) nextMilImp.nextMillennium.adSlots = adSlots
if (Array.isArray(allowedAds)) nextMilImp.nextMillennium.allowedAds = allowedAds

return nextMilImp;
}

Expand Down
37 changes: 37 additions & 0 deletions test/spec/modules/nextMillenniumBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import {
getImp,
setImpPos,
getSourceObj,
getExtNextMilImp,
replaceUsersyncMacros,
setConsentStrings,
setOrtb2Parameters,
Expand Down Expand Up @@ -1301,4 +1302,40 @@ describe('nextMillenniumBidAdapterTests', () => {
});
};
});

describe('getExtNextMilImp parameters adSlots and allowedAds', () => {
const tests = [
{
title: 'parameters adSlots and allowedAds are empty',
bid: {
params: {},
},

expected: {},
},

{
title: 'parameters adSlots and allowedAds',
bid: {
params: {
adSlots: ['test1'],
allowedAds: ['test2'],
},
},

expected: {
adSlots: ['test1'],
allowedAds: ['test2'],
},
},
];

for (const {title, bid, expected} of tests) {
it(title, () => {
const extNextMilImp = getExtNextMilImp(bid);
expect(extNextMilImp.nextMillennium.adSlots).to.deep.equal(expected.adSlots);
expect(extNextMilImp.nextMillennium.allowedAds).to.deep.equal(expected.allowedAds);
});
};
});
});
Loading