IntentIq ID Module & Analytical Adapter: increase default server call time, support region, bugfixes #14374
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| export function getUnitPosition(pbjs, adUnitCode) { | ||
| const adUnits = pbjs?.adUnits; | ||
| if (!Array.isArray(adUnits) || !adUnitCode) return; | ||
|
|
||
| for (let i = 0; i < adUnits.length; i++) { | ||
| const adUnit = adUnits[i]; | ||
| if (adUnit?.code !== adUnitCode) continue; | ||
|
|
||
| const mediaTypes = adUnit?.mediaTypes; | ||
| if (!mediaTypes || typeof mediaTypes !== 'object') return; | ||
|
|
||
| const firstKey = Object.keys(mediaTypes)[0]; | ||
| const pos = mediaTypes[firstKey]?.pos; | ||
|
|
||
| return typeof pos === 'number' ? pos : undefined; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,33 @@ | ||
| const REGION_MAPPING = { | ||
| gdpr: true, | ||
| apac: true, | ||
| emea: true | ||
| }; | ||
|
|
||
| function checkRegion(region) { | ||
| if (typeof region !== 'string') return ''; | ||
| const lower = region.toLowerCase(); | ||
| return REGION_MAPPING[lower] ? lower : ''; | ||
| } | ||
|
|
||
| function buildServerAddress(baseName, region) { | ||
| const checkedRegion = checkRegion(region); | ||
| if (checkedRegion) return `https://${baseName}-${checkedRegion}.intentiq.com`; | ||
| return `https://${baseName}.intentiq.com`; | ||
| } | ||
|
|
||
| export const getIiqServerAddress = (configParams = {}) => { | ||
| if (typeof configParams?.iiqServerAddress === 'string') return configParams.iiqServerAddress; | ||
| return buildServerAddress('api', configParams.region); | ||
|
Comment on lines
+19
to
+21
There was a problem hiding this comment.
This helper now builds API/reporting/sync base URLs solely from Useful? React with 👍 / 👎.
Contributor
Author
There was a problem hiding this comment. In our system, each partner account is provisioned for a specific region, and traffic should use the matching regional account. So region routing is intentional and explicit — the account must match the target region. |
||
| }; | ||
|
|
||
| export const iiqPixelServerAddress = (configParams = {}) => { | ||
| if (typeof configParams?.iiqPixelServerAddress === 'string') return configParams.iiqPixelServerAddress; | ||
| return buildServerAddress('sync', configParams.region); | ||
| }; | ||
|
|
||
| export const reportingServerAddress = (reportEndpoint, region) => { | ||
| if (reportEndpoint && typeof reportEndpoint === 'string') return reportEndpoint; | ||
| const host = buildServerAddress('reports', region); | ||
| return `${host}/report`; | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,7 @@ | ||
| export function appendSPData (url, partnerData) { | ||
| const spdParam = partnerData?.spd ? encodeURIComponent(typeof partnerData.spd === 'object' ? JSON.stringify(partnerData.spd) : partnerData.spd) : ''; | ||
| if (!spdParam) { | ||
| return url; | ||
| } | ||
| return `${url}&spd=${spdParam}`; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This picks the first key in
adUnit.mediaTypesto readpos. For multi-format adUnits (e.g., banner + video), object key order is not guaranteed to match the winningmediaType, so a video win can be reported with the banner pos (or undefined), corrupting analytics. Consider selectingmediaTypes[data.mediaType]?.pos(or mapping fromadType) when the event includes a media type.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
posis defined at the adUnit level and is identical across mediaTypes, so reading it from any mediaTypes entry yields the same value. We don’t depend on key order for correctness in this case.