-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New adapter - Adnimation #14502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
New adapter - Adnimation #14502
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| import {registerBidder} from '../src/adapters/bidderFactory.js'; | ||
| import {BANNER, VIDEO} from '../src/mediaTypes.js'; | ||
| import {getStorageManager} from '../src/storageManager.js'; | ||
| import { | ||
| isBidRequestValid, | ||
| onBidWon, | ||
| createUserSyncGetter, | ||
| createBuildRequestsFn, | ||
| createInterpretResponseFn | ||
| } from '../libraries/vidazooUtils/bidderUtils.js'; | ||
|
|
||
| const DEFAULT_SUB_DOMAIN = 'exchange'; | ||
| const BIDDER_CODE = 'adnimation'; | ||
| const BIDDER_VERSION = '1.0.0'; | ||
| export const storage = getStorageManager({bidderCode: BIDDER_CODE}); | ||
|
|
||
| export function createDomain(subDomain = DEFAULT_SUB_DOMAIN) { | ||
| return `https://${subDomain}.adnimation.com`; | ||
| } | ||
|
|
||
| function createUniqueRequestData(hashUrl, bid) { | ||
| const {auctionId, transactionId} = bid; | ||
| return { | ||
| auctionId, | ||
| transactionId | ||
| }; | ||
| } | ||
|
|
||
| const buildRequests = createBuildRequestsFn(createDomain, createUniqueRequestData, storage, BIDDER_CODE, BIDDER_VERSION, false); | ||
| const interpretResponse = createInterpretResponseFn(BIDDER_CODE, false); | ||
| const getUserSyncs = createUserSyncGetter({ | ||
| iframeSyncUrl: 'https://sync.adnimation.com/api/sync/iframe', | ||
| imageSyncUrl: 'https://sync.adnimation.com/api/sync/image' | ||
| }); | ||
|
|
||
| export const spec = { | ||
| code: BIDDER_CODE, | ||
| version: BIDDER_VERSION, | ||
| supportedMediaTypes: [BANNER, VIDEO], | ||
| isBidRequestValid, | ||
| buildRequests, | ||
| interpretResponse, | ||
| getUserSyncs, | ||
| onBidWon, | ||
| }; | ||
|
|
||
| registerBidder(spec); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # Overview | ||
|
|
||
| **Module Name:** Adnimation Bidder Adapter | ||
|
|
||
| **Module Type:** Bidder Adapter | ||
|
|
||
| **Maintainer:** prebid@adnimation.com | ||
|
|
||
| # Description | ||
|
|
||
| Module that connects to Adnimation's demand sources. | ||
|
|
||
| # Test Parameters | ||
|
|
||
| ```js | ||
| var adUnits = [ | ||
| { | ||
| code: 'test-ad', | ||
| sizes: [[300, 250]], | ||
| bids: [ | ||
| { | ||
| bidder: 'adnimation', | ||
| params: { | ||
| cId: '562524b21b1c1f08117667f9', | ||
| pId: '59ac17c192832d0016683fe3', | ||
| bidFloor: 0.0001, | ||
| ext: { | ||
| param1: 'loremipsum', | ||
| param2: 'dolorsitamet' | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| ]; | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adnimationwhile old alias still existsThis adapter registers
code: 'adnimation', butmodules/limelightDigitalBidAdapter.jsalready registersadnimationas an alias (line 87). BecauseregisterBidder()adds aliases by callingregisterBidAdapter()for the alias code, andregisterBidAdapter()overwrites_bidderRegistry[bidderCode]without collision checks (src/adapters/bidderFactory.ts,src/adapterManager.ts), builds that include both modules will have order-dependent behavior (one adapter silently replaces the other). In the same scenario, the alias map can still resolveadnimationtolimelightDigital, so privacy/activity resolution can target the wrong bidder.Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lksharma
Related to the comment above, can I remove the alias of the Adnimation form the limelightDigital or there is other procedure? We have a contract with the Adnimation. We have requested their approval.
Perion Mail - Adnimation Prebid Adapter - now Operated by Vidazoo _ Perion.pdf
Can you please assist here and describe how we can start to manage their adapter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go ahead and drop the alias in this pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. The alias was removed