mileRtdProvider initial commit by mohanjpAtmd · Pull Request #14636 · prebid/Prebid.js

mohanjpAtmd · 2026-03-24T14:32:10Z

Type of change

Feature

Description of change

New RTD module for Mile Tech(Automatad). This module hooks on Prebid's lifecycle events like onAuctionInitEvent and onBidResponseEvent which RTD core module provides and adds ad server targeting as key values based on an external loaded JS which provides the values.

Configuration

Use the RTD module with provider name mile:

pbjs.setConfig({
  realTimeData: {
    dataProviders: [
      {
        name: "mile",
        waitForIt: false,
        params: {
          runtimeScriptUrl: "https://cdn.example.com/mile-rtd-runtime.js",
          runtimeGlobalName: "mileRtdRuntime", // optional, default shown
        },
      },
    ],
  },
});

Params

runtimeScriptUrl (optional): URL of runtime script to load.
runtimeGlobalName (optional): global object name exposing getMileTargetingByAdUnit; defaults to mileRtdRuntime.

patmmccann · 2026-03-25T22:08:19Z

Why is prebid involved? Why don't you just have your script call the gam set targeting API?

mohanjpAtmd · 2026-03-26T06:54:13Z

Why is prebid involved? Why don't you just have your script call the gam set targeting API?

We hook on Prebid's onAuctionInitEvent and onBidResponseEvent events and we make use of RTD core module's auctionDelay or waitForIt features so that we are able to set the required ad server targeting in time.

As a RTD module it makes it easier for the publishers to integrate this functionality to their stack.

patmmccann · 2026-03-28T21:52:23Z

@codex is this module affecting the bid request or processing the bid response in any meaningful way or are they just using this module to send data to gam

chatgpt-codex-connector · 2026-03-28T21:53:09Z

Codex couldn't complete this request. Try again later.

jdcauley

A few observations after reviewing the implementation against the patterns used by the other ~51 RTD modules in this repo.

The main concern is the isFlooringEnforcedForAuction gate — this module only applies targeting when floor enforcement is active. Across the entire RTD module ecosystem, no other module gates behavior on enforceJS or enforcements, and only one (oxxionRtdProvider) even references floorData at all. This makes the module look purpose-built to influence floor pricing rather than provide general real-time targeting data.

Suggested changes:

Remove the floor enforcement gate. If the targeting data is genuinely useful for ad serving, it should apply regardless of floor state. This is the most important change to address the architectural concern.
Consider using getTargetingData() instead of direct slot.setTargeting() on GPT. Only 2-3 modules out of 51 directly manipulate GPT slots; the standard pattern (used by ~13 modules) is to return targeting through Prebid's getTargetingData() interface. This makes targeting transparent to publishers and other modules.
If the event hooks (onAuctionInitEvent/onBidResponseEvent) are needed over getTargetingData(), document why. These hooks are rare (2-3 modules each), so clarifying what they provide that the standard interface doesn't would help reviewers.

jdcauley · 2026-03-29T14:28:42Z

+      if (targetingValue != null) {
+        slot.setTargeting(TARGETING_KEY, targetingValue);
+      }
+    });


Only 2-3 out of 51 RTD modules directly manipulate GPT slots. The more common pattern (~13 modules) is to implement getTargetingData() on the submodule, which returns targeting through Prebid's pipeline and makes it visible to publishers.

Suggestion: consider replacing setSlotTargeting with a getTargetingData() implementation on the submodule definition. This would also eliminate the direct googletag dependency.

This is a great point, we should put this in our cove review guidelines and open an issue to fix the 2-3 you mention

Hi, the intent of our RTD module is to influence GAM pricing rules and we wish to do it by passing relevant targeting to the ad server(GAM). We agree with your assessment about floor enforcement gate and we have removed it.

However we require the use of setTargeting to ensure that the GAM targeting happens timely. getTargetingData on the other hand is triggered at auctionEnd which can be too late for the targeting keys to be passed to GAM because of failSafe timeouts that most publishers implement. We would want our targeting to be triggered at auctionInit and bidResponse which is not possible with your suggested method.

We also found out this GPT setTargeting pattern being used by other RTD modules, some examples of which are as below:
relevadRtdProvider
sirDataRtdProvider

Please review and let us know how to proceed, thanks.

this is the main hang up at the moment, i've opened an issue to fix those two.

This is interesting: "getTargetingData on the other hand is triggered at auctionEnd which can be too late for the targeting keys to be passed to GAM because of failSafe timeouts that most publishers implement. " and we'll talk about it in the next PMC

see #14711 and #14712 for a couple different options

i closed that pr, great point

@mohanjpAtmd please proceed with using our methods, we're picking up #14706 (comment) right away to solve the issue you identified

@mohanjpAtmd there's a pr on the board to solve the issue you flagged about targeting; we welcome your feedback

Hi @patmmccann, with this change we are able to use adUnit.adserverTargeting to set the targeting at auctionInit at ad unit level. However we also need to be able to set targeting at bidResponse event. Which utility function do you suggest we use for this?

Hi @patmmccann On testing this again we are now able to verify that adUnit.adserverTargeting approach works for us in setting the targeting on auctionInit and bidResponse events and these targetings are getting passed even when the failsafe timeout triggers before the Prebid's auctionEnd.

The change to use adUnit.adserverTargeting is committed to this branch. Please review and let us know how we can proceed.

github-actions · 2026-03-31T09:06:27Z

Whoa there partner! This project is migrating to typescript. Consider changing the new JS files to TS, with well-defined types for what interacts with the prebid public API (for example: bid params and configuration). Thanks!

modules/mileRtdProvider.js

…the RTD module

coveralls · 2026-04-03T10:20:53Z

Pull Request Test Coverage Report for Build 23860972488

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

188 of 193 (97.41%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.001%) to 96.348%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
modules/mileRtdProvider.ts	71	76	93.42%

Totals
Change from base Build 23392478268:	0.001%
Covered Lines:	216573
Relevant Lines:	224782

💛 - Coveralls

dgirardi · 2026-04-20T18:08:55Z

+      const slotElementId = slot.getSlotElementId?.();
+      const adUnitPath = slot.getAdUnitPath?.();


I recommend using isAdunitCodeMatchingSlot to keep it consistent with how the rest of prebid decides how to match ad units with GPT slots.

hi @dgirardi we need the actual slotElementId and adUnitPath values, not just checking if they match. We use them to retrieve the targetingValue as shown in line number 151.

patmmccann

should be ready to use our methods with the failsafe timeout concern fixed

mileRtdProvider initial commit

a1ecaf1

mohanjpAtmd marked this pull request as ready for review March 25, 2026 14:36

patmmccann self-assigned this Mar 28, 2026

jdcauley reviewed Mar 29, 2026

View reviewed changes

review-assignment-bot Bot requested a review from robertrmartinez March 31, 2026 09:05

JP Mohan added 2 commits April 1, 2026 19:01

removing the isFlooringEnforcedForAuction gate

8afc144

converted to typescript and removed the flooringEnforcedCheck inside …

ec0600a

…the RTD module

mohanjpAtmd requested review from jdcauley and patmmccann April 1, 2026 17:11

patmmccann reviewed Apr 2, 2026

View reviewed changes

Comment thread modules/mileRtdProvider.ts

mohanjpAtmd requested a review from patmmccann April 9, 2026 17:01

patmmccann mentioned this pull request Apr 13, 2026

rtd modules: adjust timing of settargeting methods #14706

Open

patmmccann added the pmc-review label Apr 13, 2026

dgirardi reviewed Apr 20, 2026

View reviewed changes

patmmccann requested changes May 6, 2026

View reviewed changes

using adUnit.adserverTargeting

bf6a4fd

mohanjpAtmd requested a review from patmmccann May 8, 2026 17:26

patmmccann approved these changes May 9, 2026

View reviewed changes

patmmccann added the feature label May 9, 2026

patmmccann merged commit a7618ce into prebid:master May 9, 2026
10 checks passed

review-assignment-bot Bot added the core label May 9, 2026

		const slotElementId = slot.getSlotElementId?.();
		const adUnitPath = slot.getAdUnitPath?.();

Conversation

mohanjpAtmd commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

Description of change

Configuration

Params

Uh oh!

patmmccann commented Mar 25, 2026

Uh oh!

mohanjpAtmd commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

patmmccann commented Mar 28, 2026

Uh oh!

chatgpt-codex-connector Bot commented Mar 28, 2026

Uh oh!

jdcauley left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Mar 31, 2026

Uh oh!

Uh oh!

coveralls commented Apr 3, 2026

Pull Request Test Coverage Report for Build 23860972488

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mohanjpAtmd Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

patmmccann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mohanjpAtmd commented Mar 24, 2026 •

edited

Loading

mohanjpAtmd commented Mar 26, 2026 •

edited

Loading

mohanjpAtmd Apr 22, 2026 •

edited

Loading