Skip to content

TTD Bid Adapter: Remove the test HTTP2 endpoint and set alwaysHasCapacity #14665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patmmccann merged 3 commits into from
Apr 2, 2026
Merged

TTD Bid Adapter: Remove the test HTTP2 endpoint and set alwaysHasCapacity #14665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d989c8a
Remove the HTTP2 endpoint from TTD Bid Adapter
robin-crazygames Apr 1, 2026
1f7fd71
Remove HTTP2 endpoint from test
robin-crazygames Apr 1, 2026
83ac181
Add alwaysHasCapacity property to spec
patmmccann Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions modules/ttdBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ const BIDADAPTERVERSION = 'TTD-PREBID-2025.07.15';
const BIDDER_CODE = 'ttd';
const BIDDER_CODE_LONG = 'thetradedesk';
const BIDDER_ENDPOINT = 'https://direct.adsrvr.org/bid/bidder/';
const BIDDER_ENDPOINT_HTTP2 = 'https://d2.adsrvr.org/bid/bidder/';
const USER_SYNC_ENDPOINT = 'https://match.adsrvr.org';
const TTL = 360;

Expand Down Expand Up @@ -286,15 +285,13 @@ function selectEndpoint(params) {
return params.customBidderEndpoint
}

Comment on lines 285 to 287
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve useHttp2 endpoint selection behavior

Removing the params.useHttp2 branch from selectEndpoint makes existing useHttp2: true configurations silently route to https://direct.adsrvr.org/... instead of https://d2.adsrvr.org/.... This is a backward-incompatible behavior change in the adapter contract (also reflected by the existing test/spec/modules/ttdBidAdapter_spec.js case for the HTTP2 endpoint), so callers that rely on the flag now get different production routing with no warning.

Useful? React with 👍 / 👎.

if (params.useHttp2) {
return BIDDER_ENDPOINT_HTTP2;
}
return BIDDER_ENDPOINT;
}

export const spec = {
code: BIDDER_CODE,
gvlid: 21,
alwaysHasCapacity: true,
aliases: [BIDDER_CODE_LONG],
supportedMediaTypes: [BANNER, VIDEO],

Expand Down
7 changes: 0 additions & 7 deletions test/spec/modules/ttdBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,13 +324,6 @@ describe('ttdBidAdapter', function () {
expect(url).to.equal('https://direct.adsrvr.org/bid/bidder/supplier');
});

it('sends bid requests to the correct http2 endpoint', function () {
const bannerBidRequestsWithHttp2Endpoint = deepClone(baseBannerBidRequests);
bannerBidRequestsWithHttp2Endpoint[0].params.useHttp2 = true;
const url = testBuildRequests(bannerBidRequestsWithHttp2Endpoint, baseBidderRequest).url;
expect(url).to.equal('https://d2.adsrvr.org/bid/bidder/supplier');
});

it('sends bid requests to the correct custom endpoint', function () {
const bannerBidRequestsWithCustomEndpoint = deepClone(baseBannerBidRequests);
bannerBidRequestsWithCustomEndpoint[0].params.customBidderEndpoint = 'https://customBidderEndpoint/bid/bidder/';
Expand Down
Loading