TeqBlaze Utils: migrated to TS and bug fixes#14680
Merged
Merged
Conversation
|
Tread carefully! This PR adds 134 linter errors (possibly disabled through directives):
|
Contributor
Author
|
@patmmccann Migrated the library so adapters can be created using TypeScript. Also fixed one bug discovered during the migration and another that was previously reported. Also there is some inconsistency in |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4058b9a0c7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Comment on lines
+251
to
+253
| bcat: bidderRequest?.ortb2?.bcat, | ||
| badv: bidderRequest?.ortb2?.badv, | ||
| bapp: bidderRequest?.ortb2?.bapp |
There was a problem hiding this comment.
This change drops bidderRequest.ortb2.battr from the top-level request object, so publishers who set global creative-attribute blocks via ortb2.battr will no longer have those constraints forwarded for TeqBlaze-based adapters. That is a functional regression from previous behavior and it also conflicts with the repo guidance in PR_REVIEW.md (“Global OpenRTB fields should come from bidrequest.ortb2: bcat, battr, badv”). Please keep forwarding the global battr field (or merge it safely with per-placement values) so existing blocking rules continue to apply.
Useful? React with 👍 / 👎.
|
Tread carefully! This PR adds 133 linter errors (possibly disabled through directives):
|
Collaborator
Pull Request Test Coverage Report for Build 23948156152Details
💛 - Coveralls |
patmmccann
approved these changes
Apr 3, 2026
mike-lei
pushed a commit
to wishabi/Prebid.js
that referenced
this pull request
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
TeqBlaze bidder utils migrated to TypeScript.
Fixed bug with
battrbeing extracted from wrong place.Fixed behaviour of
getUserSyncswhen no sync options are enabled