IntimateMerger Analytics Adapter : initial release#14726
Conversation
|
Whoa there partner! This project is migrating to typescript. Consider changing the new JS files to TS, with well-defined types for what interacts with the prebid public API (for example: bid params and configuration). Thanks!
Tread carefully! This PR adds 3 linter errors and 1 linter warning (possibly disabled through directives):
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8c438974ec
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Adds an initial IM (IntimateMerger) Analytics Adapter module to Prebid.js, with unit tests and module documentation, to send analytics beacons for key auction lifecycle events.
Changes:
- Introduces
modules/imAnalyticsAdapter.jsanalytics adapter capturingAUCTION_INIT,BID_WON, andAUCTION_END. - Adds unit tests validating PV and won-bid beacon behavior, batching, and consent/uid fields.
- Adds
modules/imAnalyticsAdapter.mdwith configuration and usage details.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| test/spec/modules/imAnalyticsAdapter_spec.js | Adds unit tests for PV and won-bid batching/dedup behavior and consent fields. |
| modules/imAnalyticsAdapter.md | Documents adapter purpose, required options, and example configuration. |
| modules/imAnalyticsAdapter.js | Implements the analytics adapter, beacon sending, batching, and consent/uid extraction. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Whoa there partner! This project is migrating to typescript. Consider changing the new JS files to TS, with well-defined types for what interacts with the prebid public API (for example: bid params and configuration). Thanks!
Tread carefully! This PR adds 1 linter error and 1 linter warning (possibly disabled through directives):
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Whoa there partner! This project is migrating to typescript. Consider changing the new JS files to TS, with well-defined types for what interacts with the prebid public API (for example: bid params and configuration). Thanks!
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Whoa there partner! This project is migrating to typescript. Consider changing the new JS files to TS, with well-defined types for what interacts with the prebid public API (for example: bid params and configuration). Thanks!
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…js docs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Whoa there partner! This project is migrating to typescript. Consider changing the new JS files to TS, with well-defined types for what interacts with the prebid public API (for example: bid params and configuration). Thanks!
Tread carefully! This PR adds 1 linter warning (possibly disabled through directives):
|
1 similar comment
|
Whoa there partner! This project is migrating to typescript. Consider changing the new JS files to TS, with well-defined types for what interacts with the prebid public API (for example: bid params and configuration). Thanks!
Tread carefully! This PR adds 1 linter warning (possibly disabled through directives):
|
|
Whoa there partner! This project is migrating to typescript. Consider changing the new JS files to TS, with well-defined types for what interacts with the prebid public API (for example: bid params and configuration). Thanks!
|
|
Whoa there partner! This project is migrating to typescript. Consider changing the new JS files to TS, with well-defined types for what interacts with the prebid public API (for example: bid params and configuration). Thanks!
|
|
you don't pass tests |
|
@patmmccann |
|
Perhaps try pulling master? This test isn't flakey in master, you may be affecting it in some way |
|
@codex review. Why is this test failing |
|
Codex couldn't complete this request. Try again later. |
…ytics-adapter-module
|
Whoa there partner! This project is migrating to typescript. Consider changing the new JS files to TS, with well-defined types for what interacts with the prebid public API (for example: bid params and configuration). Thanks!
|
Coverage Report for CI Build 24650094755Coverage increased (+0.004%) to 96.391%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
|
@patmmccann |
* IntimateMerger Analytics Adapter : initial release * IntimateMerger Analytics Adapter : fix event overlap * IntimateMerger Analytics Adapter : refactoring * IntimateMerger Analytics Adapter : Update modules/imAnalyticsAdapter.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * IntimateMerger Analytics Adapter : Update waitTimeout Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * IntimateMerger Analytics Adapter : Update modules/imAnalyticsAdapter.js docs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * IntimateMerger Analytics Adapter : Update docs * IntimateMerger Analytics Adapter : cid optional --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Events Captured:
AUCTION_INIT
BID_WON
AUCTION_END
Other information