Tercept Analytics Adapter: make auction window configurable#14858
Open
mdusmanalvi wants to merge 4 commits into
Open
Tercept Analytics Adapter: make auction window configurable#14858mdusmanalvi wants to merge 4 commits into
mdusmanalvi wants to merge 4 commits into
Conversation
…nce many BID_WON events were happening after 1.5 secs.
mdusmanalvi
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 34fedf6b88
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…n explicit immediate flush rather than falling back to the default.
patmmccann
approved these changes
May 11, 2026
patmmccann
reviewed
May 11, 2026
| // 1.5s window to collect BID_WON, AD_RENDER_SUCCEEDED, AD_RENDER_FAILED, BIDDER_ERROR | ||
| auction.timer = setTimeout(() => flush(args.auctionId), 1500); | ||
| // configurable window (default 5s) to collect BID_WON, AD_RENDER_SUCCEEDED, AD_RENDER_FAILED, BIDDER_ERROR | ||
| const timeout = initOptions?.analyticsBatchTimeout ?? DEFAULT_ANALYTICS_BATCH_TIMEOUT; |
Collaborator
patmmccann
requested changes
May 11, 2026
Collaborator
patmmccann
left a comment
patmmccann
left a comment
There was a problem hiding this comment.
please define a type on your new param
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
The Tercept analytics adapter was using a hardcoded 1.5s window after
AUCTION_ENDto collect post-auction events before sending the batched payload. In some publishers, manyBID_WONevents fire more than 1.5s afterAUCTION_END. This caused win events to be missed from the analytics payload.analyticsBatchTimeoutininitOptions.Other information