Skip to content

Abtshield id system prebid#14861

Merged
patmmccann merged 4 commits into
prebid:masterfrom
EDGE-NPD:abtshield-id-system-prebid
May 11, 2026
Merged

Abtshield id system prebid#14861
patmmccann merged 4 commits into
prebid:masterfrom
EDGE-NPD:abtshield-id-system-prebid

Conversation

@tzwierzchowski
Copy link
Copy Markdown

@tzwierzchowski tzwierzchowski commented May 8, 2026

Type of change

  • Feature
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other: New User ID submodule

Description of change

Adds the ABTShield User ID submodule for the Prebid.js User ID module.

This change:

  • registers abtshieldIdSystem as a userId submodule in modules/.submodules.json:5
  • adds the ABTShield ID module implementation in modules/abtshieldIdSystem.js:23
  • supports fetching an ABTShield identifier from the MCR endpoint using publisher-provided
    params.sid
  • decodes stored values under abtshieldId
  • exposes ABTShield IDs through user.eids with source abtshield.com
  • includes optional segment output in uid.ext.segments
  • maps b: 1 MCR responses to the sivt segment
  • adds TypeScript config/value interfaces in modules/abtshieldIdSystem.d.ts:1
  • adds module documentation and User ID examples in modules/abtshieldIdSystem.md:1, modules/userId/ userId.md:23, and modules/userId/eids.md:13
  • adds unit coverage for parsing, request behavior, decoding, EID output, and SIVT segment handling in
    test/spec/modules/abtshieldIdSystem_spec.js:24

Maintainer contact: support@abtshield.com

Example configuration:

pbjs.setConfig({
  userSync: {
    userIds: [{
      name: 'abtshieldId',
      params: {
        sid: 'pb.your-service-id'
      },
      storage: {
        type: 'html5',
        name: 'abtshield_id',
        expires: 1
      }
    }]
  }
});

Docs PR: prebid/prebid.github.io#6559

@tzwierzchowski tzwierzchowski marked this pull request as ready for review May 8, 2026 14:20
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4d198c3a0b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread modules/abtshieldIdSystem.js Outdated
@tzwierzchowski tzwierzchowski marked this pull request as draft May 9, 2026 17:43
Add validation to reject missing or incomplete storage configuration and enforce a 1-day minimum for `storage.expires` to bound MCR request volume. Update TypeScript definitions to make storage fields required with documentation. Add comprehensive test coverage for validation logic.
@tzwierzchowski tzwierzchowski marked this pull request as ready for review May 9, 2026 18:59
@github-actions
Copy link
Copy Markdown

Whoa there partner! This project is migrating to typescript. Consider changing the new JS files to TS, with well-defined types for what interacts with the prebid public API (for example: bid params and configuration). Thanks!

  • modules/abtshieldIdSystem.js

@patmmccann patmmccann added feature and removed core labels May 11, 2026
@patmmccann patmmccann merged commit a71c9e1 into prebid:master May 11, 2026
197 of 198 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants