TPC Adapter (DRAFT) - Opened in Error#14866
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…am-and-cleanup cleanup
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
Whoa there partner! This project is migrating to typescript. Consider changing the new JS files to TS, with well-defined types for what interacts with the prebid public API (for example: bid params and configuration). Thanks!
|
mhc-gh
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 544770142a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const syncUrl = `${USER_SYNC_ENDPOINT}?${params.toString()}`; | ||
| if (syncOptions.iframeEnabled) { | ||
| return [{ type: 'iframe', url: syncUrl }]; | ||
| } | ||
| return [{ type: 'image', url: syncUrl }]; |
There was a problem hiding this comment.
getUserSyncs currently returns https://pbs.tpcsrv.com/cookie_sync?... directly as an iframe/image URL, but that endpoint returns sync instructions rather than performing bidder redirects itself, so the browser never executes the downstream sync URLs and user ID matching is effectively skipped. In practice this means auctions that rely on getUserSyncs will lose cookie-match coverage; compare with existing PBS-style adapters in this repo (e.g. modules/tealBidAdapter.js and modules/relevantdigitalBidAdapter.js) that wrap /cookie_sync via a load-cookie HTML endpoint or explicit redirect pixels.
Useful? React with 👍 / 👎.
|
This was opened in error. |
1 participant
What
Verification
git diff upstream/master --statshows only TPC adapter files divergedgulp test --file test/spec/modules/tpcBidAdapter_spec.js --nolintpasses