Update adapter: Selectmedia#14867
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ccc022475a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| const BIDDER_CODE = 'selectmedia'; | ||
| const AD_URL = 'https://#{REGION}#.zxyvrtd.com/pbjs'; | ||
| const GVLID = 775; |
There was a problem hiding this comment.
this appears to be the gvlid of a different company
| validBidRequests: BidRequest<typeof BIDDER_CODE>[], | ||
| bidderRequest: BaseBidderRequest<typeof BIDDER_CODE> | ||
| ): AdapterRequest => { | ||
| const region = validBidRequests[0]?.params?.region; |
There was a problem hiding this comment.
why not base this on the user timezone instead of the config?
| gvlid: GVLID, | ||
| supportedMediaTypes: [BANNER, VIDEO, NATIVE], | ||
|
|
||
| isBidRequestValid: (bid) => baseIsBidRequestValid(bid) && VALID_REGIONS.has(bid.params?.region), |
There was a problem hiding this comment.
is region required? your md file never mentions it. also if you need the pub to fill it in perhaps tell them how to do so based on Intl.DateTimeFormat().resolvedOptions().timeZone or preferably, import
and examine this function from smartyadsThere was a problem hiding this comment.
or this one from escalax
Prebid.js/modules/escalaxBidAdapter.js
Line 41 in f5638f2
2 participants
Type of change
Description of change
Update from alias to a separate adapter, add support for 2 regions
Other information
Doc PR - prebid/prebid.github.io#6560