Add TCF 2.3 Disclosed Vendors segment support (#40)#49
Open
ggierak wants to merge 1 commit intoprebid:masterfrom
Open
Add TCF 2.3 Disclosed Vendors segment support (#40)#49ggierak wants to merge 1 commit intoprebid:masterfrom
ggierak wants to merge 1 commit intoprebid:masterfrom
Conversation
Parse the Disclosed Vendors segment (SegmentType=1) from TC Strings and expose it via MaxDisclosedVendorID() and DisclosedVendor(id) on the VendorConsents interface. Maintains backward compatibility with TCF 2.2 strings where the segment is absent. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Hi @ggierak, thanks for working on this. There is already an open PR addressing the same issue (#48), and it’s currently under review and close to being ready (see onfocusio#1). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VendorConsentsinterface:MaxDisclosedVendorID()andDisclosedVendor(id)0/falsewhen the segment is absent)Details
TCF 2.3 makes the Disclosed Vendors segment mandatory in TC Strings:
This segment records which vendors were disclosed to the user by the CMP. Previously,
ParseString()discarded all segments after the first.separator. Now it decodes each additional segment, identifies its type via the first 3 bits, and parses Disclosed Vendors (type1) using the same bitfield/range encoding as vendor consent.Changes
api/consent.goMaxDisclosedVendorID()andDisclosedVendor(id)toVendorConsentsinterfacevendorconsent/tcf2/consent.goParseString(), addparseDisclosedVendors()andparseSegmentRangeSection()vendorconsent/tcf2/metadata.godisclosedVendorsfield and accessor methods with nil-safe handlingvendorconsent/tcf1/metadata.govendorconsent/tcf2/consent_test.goTest plan
go test ./...)