Port FeedAd: New Adapter#3869
Merged
Merged
Conversation
EmilNadimanov
commented
Mar 27, 2025
Contributor
|
Hi folks, The functional test seems unrelated to this port. |
Collaborator
|
Functional test failure is due to a flaky test, so it can be ignored for the purpose of this PR. |
AntoxaAntoxic
previously approved these changes
Apr 14, 2025
AntoxaAntoxic
previously approved these changes
Apr 14, 2025
CTMBNara
requested changes
Apr 15, 2025
Collaborator
|
@EmilNadimanov failed IT test |
Contributor
Author
|
Huh, I didn't make any changes to the fixtures, the test or the Bidder Adapter. And it works locally. I will take a look, in the meantime I've updated the branch to be up to date with upstream master |
CTMBNara
approved these changes
Apr 17, 2025
riteshghodrao
pushed a commit
to riteshghodrao/prebid-server-java
that referenced
this pull request
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
#3718 Porting the FeedAd Bidder Adapter
🧠 Rationale behind the change
Keeping prebid-server-java up to date
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
Unit tests + an integration test for the happy case
🏎 Quality check