Test: secure-creative validation#3883
Open
marki1an wants to merge 5 commits into
Open
Conversation
osulzhenko
changed the base branch from
master
to
secure-markup-validation-update
osulzhenko
requested changes
Feb 18, 2026
Comment on lines
+850
to
+874
| url | secure | secureMarkup | ||
| "http%3A://secure-assets.${PBSUtils.randomString}.com" | NON_SECURE | SKIP.value | ||
| "http://secure-assets.${PBSUtils.randomString}.com" | NON_SECURE | SKIP.value | ||
|
|
||
| "https://secure-assets.${PBSUtils.randomString}.com" | SECURE | SKIP.value | ||
| "http://www.w3.org" | SECURE | SKIP.value | ||
| "http%3a://www.quantcast.com/adchoices" | SECURE | SKIP.value | ||
| "http://" | SECURE | SKIP.value | ||
|
|
||
| "http%3A://secure-assets.${PBSUtils.randomString}.com" | NON_SECURE | WARN.value | ||
| "http://secure-assets.${PBSUtils.randomString}.com" | NON_SECURE | WARN.value | ||
|
|
||
| "https://secure-assets.${PBSUtils.randomString}.com" | SECURE | WARN.value | ||
| "http://www.w3.org" | SECURE | WARN.value | ||
| "http%3a://www.quantcast.com/adchoices" | SECURE | WARN.value | ||
| "http://" | SECURE | WARN.value | ||
|
|
||
| "http%3A://secure-assets.${PBSUtils.randomString}.com" | NON_SECURE | ENFORCE.value | ||
| "http://secure-assets.${PBSUtils.randomString}.com" | NON_SECURE | ENFORCE.value | ||
|
|
||
| "https://secure-assets.${PBSUtils.randomString}.com" | SECURE | ENFORCE.value | ||
| "http://www.w3.org" | SECURE | ENFORCE.value | ||
| "http%3a://www.quantcast.com/adchoices" | SECURE | ENFORCE.value | ||
| "http://" | SECURE | ENFORCE.value | ||
|
|
Collaborator
There was a problem hiding this comment.
remove empty space and w3 and quantcast from hardcode. list is NOT limited by the w3 and quantcast
Collaborator
Author
There was a problem hiding this comment.
Don't see a point in making it like constant... currently we use it in one place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check