Skip to content

Pubmatic: adapter seems to crash occasionally on invalid native ads #3918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CTMBNara merged 2 commits into from
Apr 25, 2025
Merged

Pubmatic: adapter seems to crash occasionally on invalid native ads #3918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3e4a3a
Pubmatic: adapter seems to crash occasionally on invalid native ads
przemkaczmarek Apr 17, 2025
7610d7b
add test
przemkaczmarek Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/prebid/server/bidder/pubmatic/PubmaticBidder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,7 @@ private String resolveNativeAdm(String adm, List<BidderError> bidderErrors) {
}

final JsonNode nativeNode = admNode.get("native");
if (!nativeNode.isMissingNode()) {
if (nativeNode != null && !nativeNode.isMissingNode()) {
return nativeNode.toString();
}

Expand Down
22 changes: 22 additions & 0 deletions src/test/java/org/prebid/server/bidder/pubmatic/PubmaticBidderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1316,6 +1316,28 @@ public void makeBidderResponseShouldReturnFledgeAuctionConfig() throws JsonProce
assertThat(result.getIgi()).containsExactly(igi);
}

@Test
public void makeBidderResponseShouldNotModifyAdmWhenNativeNodeIsNull() throws JsonProcessingException {
// given
final ObjectNode admNode = mapper.createObjectNode().put("otherField", "value");
final BidderCall<BidRequest> httpCall = givenHttpCall(
mapper.writeValueAsString(
givenBidResponse(bidBuilder -> bidBuilder.impid("123")
.adm(admNode.toString())
.ext(mapper.valueToTree(
PubmaticBidExt.of(2, null, 12, null))))));

// when
final CompositeBidderResponse result = target.makeBidderResponse(httpCall, null);

// then
assertThat(result.getErrors()).isEmpty();
assertThat(result.getBids())
.extracting(BidderBid::getBid)
.extracting(Bid::getAdm)
.containsExactly(admNode.toString());
}

@Test
public void makeBidsShouldFail() throws JsonProcessingException {
//given
Expand Down
Loading