Code modification required for PR #3685#3923
Closed
andreacastello wants to merge 53 commits into
Closed
Conversation
Module wurfl devicedetection
…odified Device mock used in tests.
Module wurfl devicedetection
potential mock issue fix
Simplified call to virtual capabilities API
Support downloading WURFL API mock dependency from public repo
Used WURFL lowecase in module names
…ngine. Added unit tests
PREB-41: used FileSyncer and FileProcessor to update WURFL file and engine
…used collection, used Set in place of List.
…, avoid usage of Objects utility class for checking null/not null
…aml file for module config
Moved module configuration beans, removed internal yaml configuration
…ables and yaml config values
…FL file on failed update
…ue in WURFLService init and extCaps config usage
Contributor
Author
|
Wrongly opened |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the modification required by reviewers in #3685