Skip to content

Price Floor Logs Update#3924

Merged
CTMBNara merged 8 commits into
masterfrom
price-floors-logs
Apr 30, 2025
Merged

Price Floor Logs Update#3924
CTMBNara merged 8 commits into
masterfrom
price-floors-logs

Conversation

@AntoxaAntoxic
Copy link
Copy Markdown
Collaborator

@AntoxaAntoxic AntoxaAntoxic commented Apr 18, 2025

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

Price floor processing spams logs with untraceable log entries when the floors feature is incorrectly configured.

🧠 Rationale behind the change

This PR makes the PBS log account when there is a floor parsing issue and also places a message into a warning in the response instead of an error because it doesn't stop the auction.

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

Comment thread src/test/java/org/prebid/server/floors/BasicPriceFloorProcessorTest.java Outdated
@AntoxaAntoxic AntoxaAntoxic requested a review from Net-burst April 24, 2025 14:01
Comment thread src/main/java/org/prebid/server/floors/BasicPriceFloorProcessor.java Outdated
Comment thread src/main/java/org/prebid/server/floors/BasicPriceFloorProcessor.java Outdated
…floors-logs

# Conflicts:
#	src/main/java/org/prebid/server/floors/BasicPriceFloorProcessor.java
@osulzhenko osulzhenko requested a review from CTMBNara April 30, 2025 11:19
Comment thread src/main/java/org/prebid/server/floors/BasicPriceFloorProcessor.java Outdated
@osulzhenko osulzhenko requested a review from CTMBNara April 30, 2025 12:59
@CTMBNara CTMBNara merged commit 1a55dc4 into master Apr 30, 2025
6 of 7 checks passed
@CTMBNara CTMBNara deleted the price-floors-logs branch April 30, 2025 13:04
CTMBNara added a commit that referenced this pull request May 5, 2025
riteshghodrao pushed a commit to riteshghodrao/prebid-server-java that referenced this pull request Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants