Skip to content

Test: stored imp and stored request#3928

Merged
osulzhenko merged 5 commits into
stored-request-fixfrom
tests/coverage-stored-imp-and-request-case
Apr 29, 2025
Merged

Test: stored imp and stored request#3928
osulzhenko merged 5 commits into
stored-request-fixfrom
tests/coverage-stored-imp-and-request-case

Conversation

@marki1an
Copy link
Copy Markdown
Collaborator

@marki1an marki1an commented Apr 23, 2025

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes?

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@marki1an marki1an added the tests Functional or other tests label Apr 23, 2025
@marki1an marki1an self-assigned this Apr 23, 2025
pbsServiceFactory.removeContainer(pbsConfig)
}

def 'PBS should merge stored imp when appnexus bidder requested with reserve field'() {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace ' with "


then: "Bid response should contain appnexus and generic bidder"
assert response.seatbid.size() == 2
assert response.seatbid.seat.sort() == [APPNEXUS, GENERIC].sort()
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    assert response.seatbid.seat.sort() == [APPNEXUS, BidderName.GENERIC].sort()

@osulzhenko osulzhenko changed the base branch from master to stored-request-fix April 29, 2025 12:55
@osulzhenko osulzhenko merged commit 12e4909 into stored-request-fix Apr 29, 2025
6 of 7 checks passed
@osulzhenko osulzhenko deleted the tests/coverage-stored-imp-and-request-case branch April 29, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Functional or other tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants