Port Kueez: New Adapter by kim-ng93 · Pull Request #3930 · prebid/prebid-server-java

kim-ng93 · 2025-04-23T22:24:48Z

🔧 Type of changes

✨ What's the context?

What's the context for the changes?
Port Kueez adapter from Go

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

verify email contact works
NO fully dynamic hostnames
geographic host parameters are NOT required
direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

Are your changes following our code style guidelines?
Are there any breaking changes in your code?
Does your test coverage exceed 90%?
Are there any erroneous console logs, debuggers or leftover code in your changes?

…kim-ng93/prebid-server-java into S2S-2404-pbs-port-kueez-adapter

Copilot

Pull Request Overview

This PR introduces a new bid adapter for Kueez by porting the existing Go implementation to Java. Key changes include:

Implementation of the KueezBidder and its corresponding Spring configuration.
Addition of unit and integration tests to cover the adapter’s functionality.
Inclusion of a new YAML configuration file for Kueez adapter settings.

Reviewed Changes

Copilot reviewed 6 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/test/java/org/prebid/server/it/KueezTest.java	Integration test for bidding auction flow using Kueez adapter
src/test/java/org/prebid/server/bidder/kueezrtb/KueezBidderTest.java	Unit tests verifying HTTP requests, header configuration, error handling, and bid type processing
src/main/resources/bidder-config/kueezrtb.yaml	Configuration file for the Kueez adapter endpoints and usersync settings
src/main/java/org/prebid/server/spring/config/bidder/KueezConfiguration.java	Spring configuration class binding YAML properties and creating bidder dependencies
src/main/java/org/prebid/server/proto/openrtb/ext/request/kueezrtb/KueezImpExt.java	POJO for mapping bidder-specific Imp extension with JSON property 'cId'
src/main/java/org/prebid/server/bidder/kueezrtb/KueezBidder.java	Implementation of the Kueez bid adapter handling HTTP requests and bid response processing

Files not reviewed (6)

src/main/resources/static/bidder-params/kueezrtb.json: Language not supported
src/test/resources/org/prebid/server/it/openrtb2/kueezrtb/test-auction-kueezrtb-request.json: Language not supported
src/test/resources/org/prebid/server/it/openrtb2/kueezrtb/test-auction-kueezrtb-response.json: Language not supported
src/test/resources/org/prebid/server/it/openrtb2/kueezrtb/test-kueezrtb-bid-request.json: Language not supported
src/test/resources/org/prebid/server/it/openrtb2/kueezrtb/test-kueezrtb-bid-response.json: Language not supported
src/test/resources/org/prebid/server/it/test-application.properties: Language not supported

Copilot · 2025-04-23T22:25:19Z

+            throw new PreBidException(e.getMessage());
+        }


Consider enhancing the error message by adding contextual information (e.g. indicating that the error occurred while parsing the Imp extension) to aid future debugging efforts.

Suggested change

throw new PreBidException(e.getMessage());

}

throw new PreBidException("Failed to parse Imp extension: " + e.getMessage());

linux019 · 2025-05-09T07:39:47Z

+  "required": [
+    "cId"
+  ]
+}


The Golang version of this schema https://github.com/prebid/prebid-server/blob/0b91679fe610a50f898daaf3feb2a33440a33b26/static/bidder-params/kueezrtb.json#L17 restricts additional properties, where is the actual version of the schema?

@kim-ng93 can you please confirm this or create a PR updating the schema?

This should match the golang version now

AntoxaAntoxic · 2025-05-09T07:40:11Z

+    private static BidType getMediaTypeForBid(Bid bid) {
+        final Integer mType = bid.getMtype();
+        if (mType == null) {
+            throw new PreBidException("Missing MType for bid: " + bid.getId());
+        }
+        return switch (mType) {
+            case 1 -> BidType.banner;
+            case 2 -> BidType.video;
+            default -> throw new PreBidException("Could not define bid type for imp: " + bid.getImpid());
+        };
+    }


private static BidType getBidType(Integer mType) { return switch (mType) { case 1 -> BidType.banner; case 2 -> BidType.video; case null, default -> throw new PreBidException("Could not define bid type for imp: " + bid.getImpid()); }; }

AntoxaAntoxic · 2025-05-09T07:40:57Z

+import java.util.List;
+import java.util.Objects;
+
+public class KueezBidder implements Bidder<BidRequest> {


it's better to make this file and any other related start with KuezzRtb

AntoxaAntoxic · 2025-05-09T07:45:42Z

+    @Test
+    public void makeBidsShouldReturnErrorWhenImpTypeIsNotSupported() throws JsonProcessingException {
+        // given
+        final Bid bannerBid = Bid.builder().id("bidId1").impid("id1").mtype(1).build();
+        final Bid bidWithoutMtype = Bid.builder().id("bidId2").impid("id2").mtype(null).build();
+        final Bid audioBid = Bid.builder().id("bidId3").impid("id3").mtype(3).build();
+        final Bid nativeBid = Bid.builder().id("bidId4").impid("id4").mtype(4).build();
+
+        final BidderCall<BidRequest> httpCall = givenHttpCall(
+                givenBidResponse(bannerBid, bidWithoutMtype, audioBid, nativeBid));
+
+        // when
+        final Result<List<BidderBid>> result = target.makeBids(httpCall, null);
+        // then
+        assertThat(result.getErrors()).containsExactlyInAnyOrder(
+                badServerResponse("Missing MType for bid: bidId2"),
+                badServerResponse("Could not define bid type for imp: id3"),
+                badServerResponse("Could not define bid type for imp: id4"));
+        assertThat(result.getValue()).containsOnly(BidderBid.of(bannerBid, banner, "USD"));
+    }


Please split this test into separate ones based on mtype

AntoxaAntoxic · 2025-05-09T07:46:10Z

+adapters.kueezrtb.enabled=true
+adapters.kueezrtb.endpoint=http://localhost:8090/kueezrtb-exchange/


please follow an alphabetical order here

AntoxaAntoxic · 2025-05-12T07:36:18Z

+    }
+
+    @Test
+    public void makeBidsShouldReturnBidsWithTypesSuccessfully() throws JsonProcessingException {


please split this one as well

CTMBNara · 2025-05-19T10:18:50Z

@kim-ng93 Please, fix json test

osulzhenko

@kim-ng93 could you please update your PR with current master? Also, please add additional def additionalProperties field to BidderParams.groovy, because without it, functional tests can’t properly parse result from GET bidders params endpoint.

kim-ng93 added 5 commits April 22, 2025 15:08

initial commit for kueez

7b8d843

S2S-2404: add integration test

f5d098e

Merge branch 'prebid:master' into S2S-2404-pbs-port-kueez-adapter

268513d

Update KueezBidderTest.java

8a7014d

Merge branch 'S2S-2404-pbs-port-kueez-adapter' of https://github.com/…

a82a488

…kim-ng93/prebid-server-java into S2S-2404-pbs-port-kueez-adapter

kim-ng93 requested review from armando-fs, Copilot and katherynhrabik April 23, 2025 22:24

kim-ng93 self-assigned this Apr 23, 2025

Copilot AI reviewed Apr 23, 2025

View reviewed changes

kim-ng93 linked an issue Apr 23, 2025 that may be closed by this pull request

Port PR from PBS-Go: New Adapter: Kueez #3681

Closed

osulzhenko added the do not port label May 2, 2025

linux019 reviewed May 9, 2025

View reviewed changes

AntoxaAntoxic suggested changes May 9, 2025

View reviewed changes

renaming kueez files

85013e0

AntoxaAntoxic reviewed May 12, 2025

View reviewed changes

Update KueezRtbBidderTest.java

2db681d

kim-ng93 requested a review from AntoxaAntoxic May 13, 2025 23:11

AntoxaAntoxic previously approved these changes May 14, 2025

View reviewed changes

CTMBNara requested changes May 16, 2025

View reviewed changes

Comment thread src/main/java/org/prebid/server/bidder/kueezrtb/KueezRtbBidder.java

Comment thread src/main/java/org/prebid/server/spring/config/bidder/KueezRtbConfiguration.java

Comment thread src/main/resources/bidder-config/kueezrtb.yaml Outdated

requested changes

a5c2f4c

kim-ng93 dismissed AntoxaAntoxic’s stale review via a5c2f4c May 16, 2025 17:56

CTMBNara previously approved these changes May 19, 2025

View reviewed changes

Update test-kueezrtb-bid-request.json

0725eda

kim-ng93 dismissed CTMBNara’s stale review via 0725eda May 19, 2025 18:47

CTMBNara previously approved these changes May 26, 2025

View reviewed changes

osulzhenko requested changes May 26, 2025

View reviewed changes

kim-ng93 added 2 commits May 27, 2025 12:18

Merge branch 'prebid:master' into S2S-2404-pbs-port-kueez-adapter

d0aa883

Update BidderParams.groovy

6717122

kim-ng93 dismissed CTMBNara’s stale review via 6717122 May 27, 2025 20:11

osulzhenko approved these changes May 30, 2025

View reviewed changes

CTMBNara merged commit 7a3fc81 into prebid:master Jun 3, 2025
8 of 9 checks passed

riteshghodrao pushed a commit to riteshghodrao/prebid-server-java that referenced this pull request Apr 25, 2026

Port Kueez: New Adapter (prebid#3930)

f77ff33

	throw new PreBidException(e.getMessage());
	}
	throw new PreBidException("Failed to parse Imp extension: " + e.getMessage());

		adapters.kueezrtb.enabled=true
		adapters.kueezrtb.endpoint=http://localhost:8090/kueezrtb-exchange/

Conversation

kim-ng93 commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔧 Type of changes

✨ What's the context?

🧠 Rationale behind the change

🔎 New Bid Adapter Checklist

🧪 Test plan

🏎 Quality check

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Apr 23, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CTMBNara commented May 19, 2025

Uh oh!

osulzhenko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

kim-ng93 commented Apr 23, 2025 •

edited

Loading