Skip to content

Compare currencies ignoring case#3932

Merged
CTMBNara merged 3 commits into
masterfrom
fix-currencies-copmarision
Apr 29, 2025
Merged

Compare currencies ignoring case#3932
CTMBNara merged 3 commits into
masterfrom
fix-currencies-copmarision

Conversation

@CTMBNara
Copy link
Copy Markdown
Collaborator

@CTMBNara CTMBNara commented Apr 24, 2025

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

Some requests/responses carry the currency code in lowercase, whereas the expectation is for it to be uppercase.

🧠 Rationale behind the change

Currency conversion is more tolerant now because currency lookup is case-insensitive now.

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

}

@Test
public void shouldConvertBidFloorShouldReturnFalseIfCurrenciesAreSame() {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IgnoringCase

@osulzhenko osulzhenko requested a review from And1sS April 28, 2025 16:37
@CTMBNara CTMBNara merged commit c6ec875 into master Apr 29, 2025
8 checks passed
@CTMBNara CTMBNara deleted the fix-currencies-copmarision branch April 29, 2025 11:26
riteshghodrao pushed a commit to riteshghodrao/prebid-server-java that referenced this pull request Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants