New Module: LiveIntent Omni-channel Identity by 3link · Pull Request #3938 · prebid/prebid-server-java

3link · 2025-04-25T13:20:32Z

🔧 Type of changes

✨ What's the context?

This PR introduces a new module that allows enriching auctions with user EIDs using LiveIntent's identity graph.

🏎 Quality check

Are your changes following our code style guidelines?
Are there any breaking changes in your code? <- no
Does your test coverage exceed 90%?
Are there any erroneous console logs, debuggers or leftover code in your changes? <- no

3link · 2025-04-28T12:15:02Z

+        this.httpClient = Objects.requireNonNull(httpClient);
+    }
+
+    // TODO: Caching


How and whether or not to cache is being decided now.

3link · 2025-04-28T12:15:57Z

@And1sS, Can you please have a look at this draft and leave me a couple of bullet points on what might be missing?

And1sS · 2025-04-29T18:20:40Z

Hi, yes, you got the general idea right.

3link · 2025-05-21T07:21:21Z

@And1sS It looks like a prebid-server test is constantly failing. But it does not seem to be related to my changes.

Error:  Failures: 
Error:    StoredResponseSpec.PBS should set seatBids in response from multiple imp.ext.prebid.storedBidResponse.seatbidobj when it is defined:339 Condition not satisfied:

And1sS · 2025-05-26T12:45:45Z

+
+@Builder
+@Data
+@Jacksonized


We don't use this annotation. We try to avoid experimental features of Lombok as muck as possible. I also believe that it will work without that annotation.

Changed to using NoArgsConstructor in b588f6a

And1sS · 2025-05-26T12:50:33Z

+@Jacksonized
+public class IdResResponse {
+
+    @JsonProperty("eids")


Useless annotation, please remove. Since you are using default mapper - it will deserialize by name of the field.

Done in 3ed7ee8

And1sS · 2025-05-26T12:51:13Z

+public final class ModuleConfig {
+
+    long requestTimeoutMs;
+    String identityResolutionEndpoint;


Please, add separation lines between all fields.

Done in bedb969

And1sS · 2025-05-26T12:57:36Z

+            JacksonMapper mapper,
+            HttpClient httpClient) {
+
+        this(config, mapper, httpClient, new Random());


This one won't work. Default Random class is not thread safe, and module can be called on any threads concurrently. Please, to simplify code, just leave one constructor with 'RandomGenerator' as parameter (for tests) and provide it with lambda that implements that functional interface using ThreadLocalRandom like this:

() -> ThreadLocalRandom.current().nextLong()

Done in d94e06f

And1sS · 2025-05-26T13:00:30Z

+                                    .action(InvocationAction.update)
+                                    .payloadUpdate(requestPayload -> updatedPayload(requestPayload, resolutionResult))
+                                    .build()
+                    );


Please, see our styling doc on how we style our code and apply changes accordingly.

Done in 61ceeed

And1sS · 2025-05-26T13:01:50Z

+    }
+
+    @Override
+    public String code() {


Same here about method order.

Done in fa66d18

And1sS · 2025-05-26T13:03:08Z

+                "{\"eids\": [ { \"source\": \"liveintent.com\", "
+                        + "\"uids\": [ { \"atype\": 3, \"id\" : \"some_id\" } ] } ] }",
+                IdResResponse.class);
+        // when and then


Please, add nice empty line before comment to separate test stages. Also, check for similar occurrences.

Dine in 09450d2

3link · 2025-06-11T12:19:53Z

@And1sS Addressed your comments. Please let me know if you see anything else that requires changes.

osulzhenko · 2025-06-11T14:31:26Z

@3link fyi maven resolution issue:

Error: ] Some problems were encountered while processing the POMs:
[FATAL] Non-resolvable parent POM for org.prebid.server.hooks.modules:live-intent-omni-channel-identity:3.26.0-SNAPSHOT: The following artifacts could not be resolved: org.prebid.server.hooks.modules:all-modules:pom:3.26.0-SNAPSHOT (absent): Could not find artifact org.prebid.server.hooks.modules:all-modules:pom:3.26.0-SNAPSHOT and 'parent.relativePath' points at wrong local POM @ line 5, column 13
 @ 
Error:  The build could not read 1 project -> [Help 1]
Error:    
Error:    The project org.prebid.server.hooks.modules:live-intent-omni-channel-identity:3.26.0-SNAPSHOT (/home/runner/work/prebid-server-java/prebid-server-java/extra/modules/live-intent-omni-channel-identity/pom.xml) has 1 error
Error:      Non-resolvable parent POM for org.prebid.server.hooks.modules:live-intent-omni-channel-identity:3.26.0-SNAPSHOT: The following artifacts could not be resolved: org.prebid.server.hooks.modules:all-modules:pom:3.26.0-SNAPSHOT (absent): Could not find artifact org.prebid.server.hooks.modules:all-modules:pom:3.26.0-SNAPSHOT and 'parent.relativePath' points at wrong local POM @ line 5, column 13 -> [Help 2]

3link · 2025-06-11T16:15:35Z

@osulzhenko Should be fixed now.

3link · 2025-06-24T14:33:31Z

@And1sS Is anything missing for merging this PR?

And1sS · 2025-07-25T07:29:48Z

+@Configuration
+@ConditionalOnProperty(
+        prefix = "hooks." + LiveIntentOmniChannelIdentityModule.CODE, name = "enabled", havingValue = "true"
+)


Please, change parantesis placement, look at our code style guidelines.

Done in 5f15bf1

And1sS · 2025-07-25T07:30:17Z

+        this.config = Objects.requireNonNull(config);
+        this.mapper = Objects.requireNonNull(mapper);
+        this.httpClient = Objects.requireNonNull(httpClient);
+        this.random = random;


Objects.requiereNonNull here

Done in 5f15bf1

And1sS · 2025-07-25T07:30:32Z

+    public Future<InvocationResult<AuctionRequestPayload>> call(
+            AuctionRequestPayload auctionRequestPayload,
+            AuctionInvocationContext invocationContext
+    ) {


Done in 5f15bf1

And1sS · 2025-07-25T07:30:58Z

+                                    .build());
+
+            return update.onFailure(throwable -> logger.error("Failed enrichment:", throwable));
+        } else {


No need for else clause, unnecessary nesting.

Done in 5f15bf1

And1sS · 2025-07-25T07:31:25Z

+            final Future<InvocationResult<AuctionRequestPayload>> update = requestEnrichment(auctionRequestPayload)
+                    .map(resolutionResult ->
+                            InvocationResultImpl.<AuctionRequestPayload>builder()
+                                    .status(InvocationStatus.success)
+                                    .action(InvocationAction.update)
+                                    .payloadUpdate(requestPayload -> updatedPayload(requestPayload, resolutionResult))
+                                    .build());
+
+            return update.onFailure(throwable -> logger.error("Failed enrichment:", throwable));


No need for local variable, just chain calls.

Done in 5f15bf1

And1sS · 2025-07-25T07:36:31Z

+                        + ", \"id\" : \""
+                        + enrichedUid.getId() + "\" } ] } ] }");
+
+        when(


Same here, parentheses. Please, check for similar occurences.

Done in b61986a

And1sS · 2025-07-25T07:37:59Z

+                httpClient.post(
+                        eq(moduleConfig.getIdentityResolutionEndpoint()),
+                        argThat(new ArgumentMatcher<MultiMap>() {
+                            @Override
+                            public boolean matches(MultiMap entries) {
+                                return entries.contains("Authorization", "Bearer " + moduleConfig.getAuthToken(), true);
+                            }
+                        }),
+                        eq(jacksonMapper.encodeToString(bidRequest)),
+                        eq(moduleConfig.getRequestTimeoutMs())
+                )


Unreadable, please, extract matcher.

Done in 5f15bf1

And1sS · 2025-07-25T07:38:53Z

+        assertThat(future).isNotNull();
+        assertThat(future.succeeded()).isTrue();


I mean, why bother checking for null? This is unit tests. It will crash anyways.

Done in 5f15bf1

And1sS · 2025-07-25T07:40:21Z

+        assertThat(result).isNotNull();
+        assertThat(result.status()).isEqualTo(InvocationStatus.success);
+        assertThat(result.action()).isEqualTo(InvocationAction.no_action);
+        assertThat(result.payloadUpdate()).isNull();


assertThat(result).isEqualTo( InvocationResult.<AuctionRequestPayload>builder() .status(...) .action(...) .build());

Done in 5f15bf1

And1sS · 2025-07-25T07:40:46Z

+    <parent>
+        <groupId>org.prebid.server.hooks.modules</groupId>
+        <artifactId>all-modules</artifactId>
+        <version>3.27.0-SNAPSHOT</version>


Please, bump version to latest PBS version.

Done in e458a4c

# Conflicts: # extra/bundle/pom.xml # extra/modules/pom.xml

SuperIzya · 2025-08-05T15:15:06Z

@And1sS, I'll repeat @3link's question: Is anything missing for merging this PR?

And1sS · 2025-08-15T06:15:47Z

Closed in favor of #4127.
Basically, my colleague took your pr and polished it.

wi101 · 2025-08-22T09:03:50Z

Hi @And1sS
Thanks! I saw the PR has been merged.
So could we close this one?

And1sS · 2025-08-22T11:34:12Z

Hi @And1sS

Thanks! I saw the PR has been merged.

So could we close this one?

Yes

wi101 · 2025-08-22T12:00:52Z

Awesome, thanks for your answer
Could you help me to close it? because I don't have access

WIP - LiveIntent Module

bf8c1fa

3link force-pushed the cm-1776 branch from 816d3fa to bf8c1fa Compare April 25, 2025 13:24

3link added 2 commits April 25, 2025 15:29

Adjust the hook code

8429f34

WIP - polish, add config tests

459028d

osulzhenko assigned 3link Apr 25, 2025

Add unit tests

c846d1c

3link commented Apr 28, 2025

View reviewed changes

Add auth token

8348d46

3link added 6 commits May 6, 2025 13:47

Add README.md

c0f6566

Fix stage

4f90c17

Add logging

c6dc20e

Add docs

a863d0a

Format

62a4508

Impro docs

e45ccbc

3link changed the title ~~WIP - LiveIntent Module~~ New Module: LiveIntent Omni-channel Identity May 7, 2025

3link added 3 commits May 7, 2025 12:39

Add IdResResponse decode test

3dbb46a

Improve code style

69fc413

Fix Collections API usage

c1ad22f

3link marked this pull request as ready for review May 7, 2025 11:12

3link and others added 4 commits May 14, 2025 16:05

Clean up/format

26288b7

Merge branch 'prebid:master' into cm-1776

4192fa8

Format

1f1a7cf

Add treatment rate

c9659ad

3link closed this May 21, 2025

3link reopened this May 21, 2025

osulzhenko requested a review from And1sS May 26, 2025 09:41

And1sS requested changes May 26, 2025

View reviewed changes

3link added 6 commits June 11, 2025 13:19

Separate field by line

bedb969

Use RandomGenerator + ThreadLocalRandom instead of Random

d94e06f

Apply code style

61ceeed

Apply style guide: method order

fa66d18

Add empty lines to separate test stages

09450d2

Use NoArgsConstructor instead of Jacksonized

b588f6a

3link added 2 commits June 11, 2025 18:13

Merge branch 'master' into cm-1776

1ae6da8

Bump dependency version

f597339

osulzhenko added do not port and removed do not port labels Jul 4, 2025

osulzhenko requested a review from CTMBNara July 18, 2025 07:37

And1sS requested changes Jul 25, 2025

View reviewed changes

ilya added 5 commits July 29, 2025 17:33

cm-1776: PR issues fixed

5f15bf1

Merge branch 'master' into cm-1776

d6dfcc7

# Conflicts: # extra/bundle/pom.xml # extra/modules/pom.xml

Merge branch 'master' into cm-1776

53ca621

# Conflicts: # extra/bundle/pom.xml # extra/modules/pom.xml

cm-1776: PR issues fixed

b61986a

cm-1776: PR issues fixed

e458a4c

osulzhenko requested a review from And1sS August 14, 2025 07:01

osulzhenko added the do not merge Not the time for merging yet label Sep 4, 2025

Net-burst closed this Sep 4, 2025

SuperIzya deleted the cm-1776 branch February 16, 2026 13:06

		assertThat(future).isNotNull();
		assertThat(future.succeeded()).isTrue();

Conversation

3link commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔧 Type of changes

✨ What's the context?

🏎 Quality check

Uh oh!

Choose a reason for hiding this comment

Uh oh!

3link commented Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

And1sS commented Apr 29, 2025

Uh oh!

3link commented May 21, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

3link Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

3link commented Jun 11, 2025

Uh oh!

osulzhenko commented Jun 11, 2025

Uh oh!

3link commented Jun 11, 2025

Uh oh!

3link commented Jun 24, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SuperIzya Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

3link commented Apr 25, 2025 •

edited

Loading

3link commented Apr 28, 2025 •

edited

Loading

3link Jun 11, 2025 •

edited

Loading

SuperIzya Aug 5, 2025 •

edited

Loading