Skip to content

Bid adjustments rules matching strategy#3939

Merged
osulzhenko merged 6 commits into
bid-adjustments-for-price-floorsfrom
bid-adjustments-rules-matching-strategy
Jun 4, 2025
Merged

Bid adjustments rules matching strategy#3939
osulzhenko merged 6 commits into
bid-adjustments-for-price-floorsfrom
bid-adjustments-rules-matching-strategy

Conversation

@AntoxaAntoxic
Copy link
Copy Markdown
Collaborator

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

prebid/prebid-server#4271

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@AntoxaAntoxic AntoxaAntoxic changed the base branch from master to bid-adjustments-for-price-floors April 28, 2025 09:18
@AntoxaAntoxic AntoxaAntoxic self-assigned this Apr 28, 2025
@osulzhenko osulzhenko requested a review from CTMBNara May 9, 2025 08:09
@osulzhenko osulzhenko added do not merge Not the time for merging yet and removed do not merge Not the time for merging yet labels May 23, 2025
marki1an and others added 2 commits May 28, 2025 11:46
…-price-floors' into bid-adjustments-rules-matching-strategy

# Conflicts:
#	src/test/groovy/org/prebid/server/functional/tests/BidAdjustmentSpec.groovy
osulzhenko and others added 3 commits June 4, 2025 11:32
…-price-floors' into bid-adjustments-rules-matching-strategy

# Conflicts:
#	src/test/groovy/org/prebid/server/functional/tests/BidAdjustmentSpec.groovy
…' into bid-adjustments-rules-matching-strategy

# Conflicts:
#	src/test/java/org/prebid/server/bidadjustments/FloorAdjustmentsResolverTest.java
@osulzhenko osulzhenko merged commit 950b608 into bid-adjustments-for-price-floors Jun 4, 2025
1 check passed
@osulzhenko osulzhenko deleted the bid-adjustments-rules-matching-strategy branch June 4, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants