Port Mobkoi: New Adapter#3942
Merged
CTMBNara merged 7 commits intoJun 4, 2025
Merged
Conversation
AntoxaAntoxic
suggested changes
May 8, 2025
AntoxaAntoxic
suggested changes
May 12, 2025
AntoxaAntoxic
previously approved these changes
May 14, 2025
Contributor
Author
|
@AntoxaAntoxic, do you think the failing test is related to my PR? I don't see the mobkoi keyword in the error output. |
Collaborator
|
@mbonnafon no worries, they are unstable from time to time |
CTMBNara
requested changes
May 16, 2025
Comment on lines
+96
to
+104
| private String resolveEndpoint(String customUri) { | ||
| try { | ||
| HttpUtil.validateUrl(customUri); | ||
| final URI uri = new URI(customUri); | ||
| return uri.resolve("/bid").toString(); | ||
| } catch (IllegalArgumentException | URISyntaxException e) { | ||
| return endpointUrl; | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Point 5.2: Fully dynamic hostnames in URLs aren't allowed in bid adapters.
Please, add a comment for that method:
// url is already validated with `bidder-params` json schema
Also, you can remove HttpUtil.validateUrl(customUri); step
Contributor
Author
There was a problem hiding this comment.
@CTMBNara, so we take the assumption that all custom URIs are valid?
Collaborator
There was a problem hiding this comment.
@mbonnafon this check will be done by new Uri().toString()
CTMBNara
requested changes
May 26, 2025
Comment on lines
+97
to
+99
| if (customUri == null) { | ||
| return endpointUrl; | ||
| } |
Collaborator
There was a problem hiding this comment.
Move it outside of try catch block
Comment on lines
-111
to
-124
| @Test | ||
| public void makeHttpRequestsShouldConstructorEndpointWhenTheCustomIsInvalidInMobkoiExtension() { | ||
| // given | ||
| final ObjectNode mobkoiExt = impExt("pid", "invalid-URI"); | ||
| final BidRequest bidRequest = givenBidRequest(impBuilder -> impBuilder.ext(mobkoiExt)); | ||
|
|
||
| // when | ||
| final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest); | ||
|
|
||
| // then | ||
| assertThat(result.getValue()).extracting(HttpRequest::getUri).containsExactly("https://test.endpoint.com/bid"); | ||
| assertThat(result.getErrors()).isEmpty(); | ||
| } | ||
|
|
CTMBNara
approved these changes
Jun 3, 2025
Contributor
Author
|
@AntoxaAntoxic @CTMBNara Thanks both for the reviews! What's the next step before merging? |
Contributor
Author
|
Hi @AntoxaAntoxic / @CTMBNara out of curiosity, do you have any visibility on the next release window? |
riteshghodrao
pushed a commit
to riteshghodrao/prebid-server-java
that referenced
this pull request
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
New bidder adapter for Mobkoi, port from PBS-Go.
Maintainer: platformteam@mobkoi.com
Related Changes:
🔎 New Bid Adapter Checklist
🧪 Test plan
The endpoint is not yet in production, so no impact.
🏎 Quality check