Skip to content

Tests: fix alert.general metric conflict#3943

Merged
CTMBNara merged 1 commit into
masterfrom
functional-tests/fix-alert.general-metric-conflict
Apr 30, 2025
Merged

Tests: fix alert.general metric conflict#3943
CTMBNara merged 1 commit into
masterfrom
functional-tests/fix-alert.general-metric-conflict

Conversation

@osulzhenko
Copy link
Copy Markdown
Collaborator

@osulzhenko osulzhenko commented Apr 30, 2025

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes?

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@osulzhenko osulzhenko added tests Functional or other tests do not port labels Apr 30, 2025
@osulzhenko osulzhenko requested review from CTMBNara and marki1an April 30, 2025 16:26
@osulzhenko osulzhenko self-assigned this Apr 30, 2025
Copy link
Copy Markdown
Collaborator

@Net-burst Net-burst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CTMBNara CTMBNara merged commit a779d4f into master Apr 30, 2025
8 checks passed
@CTMBNara CTMBNara deleted the functional-tests/fix-alert.general-metric-conflict branch April 30, 2025 16:40
CTMBNara added a commit that referenced this pull request May 5, 2025
riteshghodrao pushed a commit to riteshghodrao/prebid-server-java that referenced this pull request Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not port tests Functional or other tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants