Tests: Increase coverage for floors logs tests#3945
Closed
osulzhenko wants to merge 3 commits into
Closed
Conversation
marki1an
requested changes
May 5, 2025
| id = UUID.randomUUID() | ||
| impid = imp.id | ||
| price = PBSUtils.getRandomPrice() | ||
| price = imp.bidFloor != null ? PBSUtils.getRandomPrice(imp.bidFloor) : PBSUtils.getRandomPrice() |
Collaborator
There was a problem hiding this comment.
Looks like we should apply imp.bidFloor != null ? imp.bidFloor : PBSUtils.getRandomPrice()
| "request ${bidRequest.id}, reason: ${URL_EMPTY_WARNING_MESSAGE("$BASIC_FETCH_URL$bidRequest.accountId", message)}" | ||
| } | ||
| // Required: Sync no longer logs "in progress"—only "none" or "error" statuses are recorded | ||
| protected static final String FETCHING_DISABLED_ERROR = 'Fetching is disabled' |
Collaborator
There was a problem hiding this comment.
- Please removethe comment
- Please use double quotes, not a single "Fetching is disabled"
| } | ||
|
|
||
| def "PBS shouldn't emit error in log and response when floors is not in request and floors fetching disabled for account"() { | ||
| given: "Account with disabled fetching" |
Comment on lines
+1679
to
+1680
| and: "Flush metrics" | ||
| flushMetrics(floorsPbsService) |
Collaborator
There was a problem hiding this comment.
Move this block before where:
It isn't mandatory, it's rather a code style for us.
Also, it can be applied to other
| bidRequest << [BidRequest.getDefaultBidRequest(), getBidRequestWithFloors().tap { it.ext.prebid.floors = null }] | ||
| } | ||
|
|
||
| def "PBS should emit error in log and response when data is invalid and floors fetching disabled for account and enabled for request"() { |
Collaborator
There was a problem hiding this comment.
"PBS should emit error in log and response when floor data is empty and floors fetching disabled for account and enabled for request"
Comment on lines
+114
to
+116
| static BigDecimal getRandomPrice(BigDecimal min, BigDecimal max = 10, int scale = 3) { | ||
| getRandomDecimal(min, max).setScale(scale, HALF_UP) | ||
| } |
Collaborator
There was a problem hiding this comment.
Don't see a point to have it
Comment on lines
+1631
to
+1635
| def priceFloors = new AccountPriceFloorsConfig(enabled: true, fetch: new PriceFloorsFetch(enabled: false)) | ||
| def accountAuctionConfig = new AccountAuctionConfig(priceFloors: priceFloors) | ||
| def accountConfig = new AccountConfig(auction: accountAuctionConfig) | ||
| def account = new Account(uuid: bidRequest.accountId, config: accountConfig) | ||
| accountDao.save(account) |
Collaborator
There was a problem hiding this comment.
Here you can use getAccountWithEnabledFetch method and just with
.tap{
...priceFloors.enabled = false
}
| assert metrics[ALERT_GENERAL] == 1 | ||
| } | ||
|
|
||
| def "PBS shouldn't emit error in log and response when data is invalid and floors fetching disabled for account and #requestFloors for request"() { |
Collaborator
There was a problem hiding this comment.
same here:
"PBS shouldn't emit error in log and response when floor data is empty and floors fetching disabled for account and #requestFloors for request"
| assert metrics[ALERT_GENERAL] == 1 | ||
| } | ||
|
|
||
| def "PBS shouldn't emit error or warning when floors for account configured correctly"() { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check