Tests: Increase coverage for floors logs tests#3952
Merged
osulzhenko merged 13 commits intoMay 19, 2025
Conversation
…nflict' into functional-tests/price-floors-logs
marki1an
requested changes
May 16, 2025
| assert response.ext?.warnings[PREBID]*.message == [WARNING_MESSAGE(message)] | ||
| } | ||
|
|
||
| def "PBS shouldn't emit error in log and response when floors is not in request and floors fetching disabled for account"() { |
Collaborator
There was a problem hiding this comment.
Please add account with disabled fetching
Collaborator
Author
There was a problem hiding this comment.
it's right under comment
| requestFloors << [null, true] | ||
| } | ||
|
|
||
| def "PBS shouldn't emit error in log and response when floor data is empty and floors fetching disabled for account and disabled for request"() { |
Collaborator
There was a problem hiding this comment.
PBS shouldn't emit error in log and response when floor data is empty and floors fetching disabled for account and request
| assert metrics[ALERT_GENERAL] == 1 | ||
|
|
||
| where: | ||
| requestFloors << [null, true] |
Collaborator
There was a problem hiding this comment.
requestEnabledFloors << [null, true]
Comment on lines
+1852
to
+1853
| config.auction.priceFloors.enabled = true | ||
| config.auction.priceFloors.fetch.enabled = true |
Collaborator
There was a problem hiding this comment.
it's enabled by default in getAccountWithEnabledFetch method
| assert !metrics[ALERT_GENERAL] | ||
|
|
||
| where: | ||
| requestFloors << [null, true] |
| requestFloors << [null, true] | ||
| } | ||
|
|
||
| def "PBS shouldn't emit error in log and response when data is invalid and floors disabled for request"() { |
Collaborator
There was a problem hiding this comment.
This one looks like the same as PBS shouldn't emit error in log and response when floor data is empty and floors fetching disabled for account and disabled for request
| assert !bidResponse.ext?.errors | ||
|
|
||
| and: "PBS shouldn't log a errors" | ||
| def message = 'Price floor rules data must be present' |
Collaborator
There was a problem hiding this comment.
Suggested change
| def message = 'Price floor rules data must be present' | |
| def message = "Price floor rules data must be present" |
marki1an
requested changes
May 16, 2025
| requestFloors << [null, true] | ||
| } | ||
|
|
||
| def "PBS shouldn't emit error in log and response when data is invalid and floors disabled for request"() { |
marki1an
requested changes
May 19, 2025
| def response = floorsPbsService.sendAuctionRequest(bidRequest) | ||
|
|
||
| then: "PBS should log a warning" | ||
| def message = 'Price floor rules data must be present' |
Collaborator
There was a problem hiding this comment.
Minor
Suggested change
| def message = 'Price floor rules data must be present' | |
| def message = "Price floor rules data must be present" |
marki1an
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check