Rubicon Adapter: set additional meta fields#3960
Merged
Merged
Conversation
CTMBNara
approved these changes
May 16, 2025
muuki88
reviewed
Jun 12, 2025
|
|
||
| if (jsonNode.isTextual()) { | ||
| try { | ||
| return Integer.parseInt(jsonNode.asText()); |
Contributor
There was a problem hiding this comment.
Using exceptions for control flow can burn quite a lot of CPU power, due to exceptions being created and immediately thrown away.
I would recommend first checking if the text node can be converted to an Int and then parse it. Feel free to read the blog post I wrote, when I got hit very hard by this 😅 https://medium.com/@muuki88/follow-the-stacktraces-jvm-performance-profiling-3c371d323e5f
riteshghodrao
pushed a commit
to riteshghodrao/prebid-server-java
that referenced
this pull request
Apr 25, 2026
Co-authored-by: osulzhenko <osulzhenko@magnite.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check