Skip to content

Revert "Dependencies: Change spring-boot version (#3954)"#3968

Merged
CTMBNara merged 1 commit into
masterfrom
change-boot-version
May 20, 2025
Merged

Revert "Dependencies: Change spring-boot version (#3954)"#3968
CTMBNara merged 1 commit into
masterfrom
change-boot-version

Conversation

@osulzhenko
Copy link
Copy Markdown
Collaborator

@osulzhenko osulzhenko commented May 20, 2025

This reverts commit 46cdf39.

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes?

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@osulzhenko osulzhenko requested a review from CTMBNara May 20, 2025 14:03
@osulzhenko osulzhenko self-assigned this May 20, 2025
@osulzhenko osulzhenko added dependencies Pull requests that update a dependency file do not port labels May 20, 2025
@CTMBNara CTMBNara merged commit 25587d6 into master May 20, 2025
5 of 6 checks passed
@CTMBNara CTMBNara deleted the change-boot-version branch May 20, 2025 14:05
riteshghodrao pushed a commit to riteshghodrao/prebid-server-java that referenced this pull request Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file do not port

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants