Skip to content

Ogury: Enable in app traffic#3975

Merged
CTMBNara merged 2 commits into
prebid:masterfrom
Ogury:ADV-26955-enable-ogury-in-app-traffic
Jun 10, 2025
Merged

Ogury: Enable in app traffic#3975
CTMBNara merged 2 commits into
prebid:masterfrom
Ogury:ADV-26955-enable-ogury-in-app-traffic

Conversation

@krdzo
Copy link
Copy Markdown
Contributor

@krdzo krdzo commented May 27, 2025

🔧 Type of changes

  • bid adapter update
  • new feature

✨ What's the context?

What's the context for the changes?

Enable app traffic for Ogury adapter
Port of prebid/prebid-server#4314

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@osulzhenko osulzhenko requested a review from CTMBNara May 28, 2025 07:59
@osulzhenko osulzhenko linked an issue May 30, 2025 that may be closed by this pull request
Comment on lines +73 to +78
if (isAppRequest(bidRequest)) {
if (!isValidAppRequestKeys(impsWithOguryParams)) {
errors.add(BidderError.badInput("Invalid request. assetKey/adUnitId required"));
return Result.withErrors(errors);
}
} else if (!isValidSiteRequestKeys(bidRequest, impsWithOguryParams)) {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (CollectionUtils.isEmpty(impsWithOguryParams)) {
   if (request.getApp() != null) {
      errors.add(...);
      return ...;
   }
   
   if (!isValidSiteRequestKeys(bidRequest)) {
      errors.add(...);
      return ...;
   }
}

@krdzo krdzo force-pushed the ADV-26955-enable-ogury-in-app-traffic branch from 6a4d3f5 to e221854 Compare June 5, 2025 09:02
@osulzhenko osulzhenko requested a review from CTMBNara June 5, 2025 21:35
@krdzo
Copy link
Copy Markdown
Contributor Author

krdzo commented Jun 9, 2025

Hello @CTMBNara
I see that this build fails but I don't know what to do to fix it. Is there something that I can do because I don't see that it's was caused by my changes.
Can you help me debug and fix this?

@krdzo krdzo force-pushed the ADV-26955-enable-ogury-in-app-traffic branch from e221854 to 08995e9 Compare June 10, 2025 07:40
@CTMBNara CTMBNara merged commit d2129ab into prebid:master Jun 10, 2025
8 checks passed
@osulzhenko osulzhenko linked an issue Jun 13, 2025 that may be closed by this pull request
riteshghodrao pushed a commit to riteshghodrao/prebid-server-java that referenced this pull request Apr 25, 2026
@krdzo krdzo deleted the ADV-26955-enable-ogury-in-app-traffic branch May 7, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port PR from PBS-Go: Ogury: Enable in app traffic

2 participants