Ogury: Enable in app traffic#3975
Merged
CTMBNara merged 2 commits intoJun 10, 2025
Merged
Conversation
CTMBNara
requested changes
Jun 4, 2025
Comment on lines
+73
to
+78
| if (isAppRequest(bidRequest)) { | ||
| if (!isValidAppRequestKeys(impsWithOguryParams)) { | ||
| errors.add(BidderError.badInput("Invalid request. assetKey/adUnitId required")); | ||
| return Result.withErrors(errors); | ||
| } | ||
| } else if (!isValidSiteRequestKeys(bidRequest, impsWithOguryParams)) { |
Collaborator
There was a problem hiding this comment.
if (CollectionUtils.isEmpty(impsWithOguryParams)) {
if (request.getApp() != null) {
errors.add(...);
return ...;
}
if (!isValidSiteRequestKeys(bidRequest)) {
errors.add(...);
return ...;
}
}
6a4d3f5 to
e221854
Compare
CTMBNara
approved these changes
Jun 6, 2025
Contributor
Author
|
Hello @CTMBNara |
e221854 to
08995e9
Compare
CTMBNara
approved these changes
Jun 10, 2025
riteshghodrao
pushed a commit
to riteshghodrao/prebid-server-java
that referenced
this pull request
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
Enable app traffic for Ogury adapter
Port of prebid/prebid-server#4314
🏎 Quality check