Skip to content

Bid Ranking#3977

Merged
CTMBNara merged 8 commits into
masterfrom
bid-ranking
Jun 10, 2025
Merged

Bid Ranking#3977
CTMBNara merged 8 commits into
masterfrom
bid-ranking

Conversation

@AntoxaAntoxic
Copy link
Copy Markdown
Collaborator

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

prebid/prebid-server#4150

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@AntoxaAntoxic AntoxaAntoxic self-assigned this May 29, 2025
@AntoxaAntoxic AntoxaAntoxic requested a review from CTMBNara May 29, 2025 09:01
# Conflicts:
#	src/main/java/org/prebid/server/settings/model/AccountAuctionConfig.java
Comment thread src/main/java/org/prebid/server/auction/BidResponseCreator.java Outdated
Comment thread src/main/java/org/prebid/server/auction/BidResponseCreator.java
Comment thread src/main/java/org/prebid/server/auction/BidResponseCreator.java
AntoxaAntoxic and others added 4 commits June 6, 2025 11:10
Co-authored-by: antonbabak <ababak@magnite.com>
# Conflicts:
#	src/test/groovy/org/prebid/server/functional/model/response/auction/Bid.groovy
@osulzhenko osulzhenko requested a review from CTMBNara June 10, 2025 11:28
CTMBNara
CTMBNara previously approved these changes Jun 10, 2025
Comment thread src/main/java/org/prebid/server/auction/BidResponseCreator.java Outdated
@CTMBNara CTMBNara merged commit c8c0c13 into master Jun 10, 2025
5 of 6 checks passed
@CTMBNara CTMBNara deleted the bid-ranking branch June 10, 2025 12:55
riteshghodrao pushed a commit to riteshghodrao/prebid-server-java that referenced this pull request Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants