New Adapter: Sparteo#3985
Merged
Merged
Conversation
t-sormonte
force-pushed
the
New-Adapter--Sparteo
branch
2 times, most recently
from
bf1549b to
70b88dd
Compare
AntoxaAntoxic
suggested changes
Jun 20, 2025
Contributor
Author
|
Hi @AntoxaAntoxic , |
AntoxaAntoxic
suggested changes
Jun 25, 2025
AntoxaAntoxic
suggested changes
Jun 27, 2025
AntoxaAntoxic
suggested changes
Jun 27, 2025
Collaborator
AntoxaAntoxic
left a comment
AntoxaAntoxic
left a comment
There was a problem hiding this comment.
the bidder itself looks good, some comments on the test class
Collaborator
AntoxaAntoxic
left a comment
AntoxaAntoxic
left a comment
There was a problem hiding this comment.
Overall, looks good. Only minor issues are left. Thank you!
t-sormonte
force-pushed
the
New-Adapter--Sparteo
branch
from
53c2d04 to
5f5206f
Compare
Contributor
Author
|
Hey @AntoxaAntoxic, |
Collaborator
AntoxaAntoxic
left a comment
AntoxaAntoxic
left a comment
There was a problem hiding this comment.
one minor comment, but everything else looks good
the next step is the second approval and merging after all
t-sormonte
force-pushed
the
New-Adapter--Sparteo
branch
from
5f5206f to
c2f1822
Compare
AntoxaAntoxic
previously approved these changes
Jul 8, 2025
Contributor
Author
|
Hi @CTMBNara, just a friendly follow-up on this PR. |
CTMBNara
requested changes
Jul 28, 2025
t-sormonte
force-pushed
the
New-Adapter--Sparteo
branch
from
c2f1822 to
6bbbff7
Compare
Contributor
Author
|
Hi @CTMBNara, |
t-sormonte
force-pushed
the
New-Adapter--Sparteo
branch
from
6bbbff7 to
4c0ad2e
Compare
CTMBNara
requested changes
Jul 31, 2025
t-sormonte
force-pushed
the
New-Adapter--Sparteo
branch
from
4c0ad2e to
c606fab
Compare
Contributor
Author
|
Hi @CTMBNara |
CTMBNara
approved these changes
Aug 12, 2025
Contributor
Author
|
Hi @CTMBNara and @AntoxaAntoxic , |
riteshghodrao
pushed a commit
to riteshghodrao/prebid-server-java
that referenced
this pull request
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
We would like to allow our partners to be able to include us in s2s bidding.
The Go PR: prebid/prebid-server#4275
🧠 Rationale behind the change
The adapter logic is the same as the one we have implemented for the GO version
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
We have implemented the unit and integration test.
We have run several manual "real" tests.
🏎 Quality check