Skip to content

Housekeeping: Remove unused DB clients#4026

Closed
Net-burst wants to merge 1 commit into
masterfrom
housekeeping/remove-unused-db-clients
Closed

Housekeeping: Remove unused DB clients#4026
Net-burst wants to merge 1 commit into
masterfrom
housekeeping/remove-unused-db-clients

Conversation

@Net-burst
Copy link
Copy Markdown
Collaborator

@Net-burst Net-burst commented Jun 18, 2025

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

PBS uses asynchronous VertX DB clients. For some reason we had synchronous MySQL and PostgreSQL clients defined in pom.xml

🧠 Rationale behind the change

Those 2 dependencies are unused. If private fork would want to use synchronous DB clients for some reason, they can re-add the dependencies.

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

Existing tests should be more than enough.

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@osulzhenko
Copy link
Copy Markdown
Collaborator

osulzhenko commented Jun 18, 2025

@Net-burst we need those dependencies for functional tests — maybe just use test scope?
#4017

@Net-burst
Copy link
Copy Markdown
Collaborator Author

Closing as this is superseeded by #4017

@Net-burst Net-burst closed this Jun 18, 2025
@Net-burst Net-burst deleted the housekeeping/remove-unused-db-clients branch June 18, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants