Housekeeping: Remove unused DB clients#4026
Closed
Net-burst wants to merge 1 commit into
Closed
Conversation
Collaborator
|
@Net-burst we need those dependencies for functional tests — maybe just use test scope? |
Collaborator
Author
|
Closing as this is superseeded by #4017 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
PBS uses asynchronous VertX DB clients. For some reason we had synchronous MySQL and PostgreSQL clients defined in pom.xml
🧠 Rationale behind the change
Those 2 dependencies are unused. If private fork would want to use synchronous DB clients for some reason, they can re-add the dependencies.
🔎 New Bid Adapter Checklist
🧪 Test plan
Existing tests should be more than enough.
🏎 Quality check