optable-targeting: Fix query string construction when IDs are missing.#4138
Merged
CTMBNara merged 1 commit intoAug 21, 2025
Merged
Conversation
CTMBNara
approved these changes
Aug 20, 2025
riteshghodrao
pushed a commit
to riteshghodrao/prebid-server-java
that referenced
this pull request
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
When there was no input IDs extracted from the incoming request to be sent to Optable Targeting Endpoint - the query string appended to the main endpoint (already containing &t=&o= parameters) would be formed without a leading
&essentially leading to query strings like&t=tenant&origin=origingdpr=0instead of&t=tenant=tenant&origin=origin&gdpr=0- that lead to Targeting API requests failing with a 404. The test was there, but the test itself was incorrect, thus the bug was not caught :( The code and test are fixed now.🧠 Rationale behind the change
To eliminate the majority of Targeting API calls resulting in 404s in production
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check