Skip to content

Connatix Bid Adapter: adds GPP macros#4184

Merged
CTMBNara merged 2 commits into
prebid:masterfrom
karimMourra:advs-3239
Sep 19, 2025
Merged

Connatix Bid Adapter: adds GPP macros#4184
CTMBNara merged 2 commits into
prebid:masterfrom
karimMourra:advs-3239

Conversation

@karimMourra
Copy link
Copy Markdown
Contributor

@karimMourra karimMourra commented Sep 9, 2025

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes?
Adds macros for GPP
equivalent in Go: prebid/prebid-server#4525

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

cookie-family-name: connatix
iframe:
url: "https://capi.connatix.com/us/pixel?pId=53&gdpr={{gdpr}}&gdpr_consent={{gdpr_consent}}&us_privacy={{us_privacy}}&callback={{redirect_url}}"
url: "https://capi.connatix.com/us/pixel?pId=53&gdpr={{gdpr}}&gdpr_consent={{gdpr_consent}}&us_privacy={{us_privacy}}&gpp={{.GPP}}&gpp_sid={{.GPPSID}}&callback={{redirect_url}}"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the macro to a PBS-Java flavour. For both urls.
From this:
&gpp={{.GPP}}&gpp_sid={{.GPPSID}}

To this:
&gpp={{gpp}}&gpp_sid={{gpp_sid}}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! addressed!

Copy link
Copy Markdown
Collaborator

@Net-burst Net-burst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CTMBNara CTMBNara merged commit a22c6b7 into prebid:master Sep 19, 2025
7 of 8 checks passed
riteshghodrao pushed a commit to riteshghodrao/prebid-server-java that referenced this pull request Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants