Test: Fix default value of targeting.hb_pb#4191
Merged
osulzhenko merged 2 commits intoSep 29, 2025
Merged
Conversation
osulzhenko
added
tests
marki1an
requested changes
Sep 26, 2025
| assert targetingKeyMap["hb_pb"] == String.format("%,.2f", max.setScale(precision, RoundingMode.DOWN)) | ||
| } | ||
|
|
||
| def "PBS auction shouldn't delete bid and update targeting if price equal zero and dealId it present"() { |
Collaborator
There was a problem hiding this comment.
Suggested change
| def "PBS auction shouldn't delete bid and update targeting if price equal zero and dealId it present"() { | |
| def "PBS auction shouldn't delete bid and update targeting if price equal zero and dealId present"() { |
Collaborator
There was a problem hiding this comment.
Please add method to the end of the spec.
Comment on lines
+554
to
+560
| and: "Create and save stored response with zero prise into DB" | ||
| def storedBidResponse = BidResponse.getDefaultBidResponse(bidRequest).tap { | ||
| seatbid[0].bid[0].price = 0 | ||
| seatbid[0].bid[0].dealid = PBSUtils.randomNumber | ||
| } | ||
| def storedResponse = new StoredResponse(responseId: storedBidResponseId, storedBidResponse: storedBidResponse) | ||
| storedResponseDao.save(storedResponse) |
Collaborator
There was a problem hiding this comment.
I'm not sure, but I hope we can replace storeBidResponse with bidder.setResponse(bidRequest.id, bidResponse)
Comment on lines
+567
to
+569
| assert targetingKeyMap["hb_pb"] == '0.0' | ||
| assert targetingKeyMap["hb_pb_generic"] == '0.0' | ||
| } |
Collaborator
There was a problem hiding this comment.
Can create a const for "0.0"
osulzhenko
force-pushed
the
functional-tests/targeting-hb-pb-fix
branch
from
8f9d614 to
770da27
Compare
marki1an
approved these changes
Sep 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check