Test: Vtrack account ttl#4241
Merged
Merged
Conversation
osulzhenko
requested changes
Oct 17, 2025
| then: "Pbs should emit creative_ttl.xml with lowest value" | ||
| def metrics = defaultPbsService.sendCollectedMetricsRequest() | ||
| def minTllSecond = PBSUtils.getMinValue(requestedTtl, accountTtl) | ||
| assert metrics[XML_CREATIVE_TTL_ACCOUNT_METRIC.formatted(accountId)] == minTllSecond |
Collaborator
There was a problem hiding this comment.
assert metrics[XML_CREATIVE_TTL_ACCOUNT_METRIC.formatted(accountId)] == [requestedTtl, accountTtl].findAll().min()
| } | ||
| } | ||
|
|
||
| static Integer getMinValue(Integer valueOne, Integer valueTwo) { |
| PBSUtils.getRandomNumber(300, 1500) as Integer | PBSUtils.getRandomNumber(300, 1500) as Integer | ||
| PBSUtils.getRandomNumber(300, 1500) as Integer | PBSUtils.getRandomNegativeNumber(-300, -1500) as Integer | ||
| PBSUtils.getRandomNegativeNumber(-300, -1500) as Integer | PBSUtils.getRandomNumber(300, 1500) as Integer | ||
| PBSUtils.getRandomNegativeNumber(-300, -1500) as Integer | PBSUtils.getRandomNegativeNumber(-300, -1500) as Integer |
Collaborator
There was a problem hiding this comment.
Is a negative value even legit?
osulzhenko
requested changes
Oct 20, 2025
| assert exception.responseBody == "Account 'a' is required query parameter and can't be empty" | ||
| } | ||
|
|
||
| def "PBS shouldn't negative value in tllSecond when account vtrack ttl is #accountTtl and request ttl second is #requestedTtl"() { |
Collaborator
There was a problem hiding this comment.
PBS shouldn't use negative value
| then: "Pbs should emit creative_ttl.xml with lowest value" | ||
| def metrics = defaultPbsService.sendCollectedMetricsRequest() | ||
| assert metrics[XML_CREATIVE_TTL_ACCOUNT_METRIC.formatted(accountId)] | ||
| == [requestedTtl, accountTtl].findAll({ it -> it > 0 }).min() |
Collaborator
There was a problem hiding this comment.
[requestedTtl, accountTtl].findAll { it > 0 }.min()
| then: "Pbs should emit creative_ttl.xml with lowest value" | ||
| def metrics = defaultPbsService.sendCollectedMetricsRequest() | ||
| assert metrics[XML_CREATIVE_TTL_ACCOUNT_METRIC.formatted(accountId)] | ||
| == [requestedTtl, accountTtl].findAll().min() |
Collaborator
There was a problem hiding this comment.
[requestedTtl, accountTtl].min()
osulzhenko
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check