New Adapter: Adagio by GodefroiRoussel · Pull Request #4300 · prebid/prebid-server

GodefroiRoussel · 2025-04-14T16:22:31Z

Here is the documentation: prebid/prebid.github.io#5993

github-actions · 2025-04-14T16:23:08Z

+			}
+
+			typedBid := &adapters.TypedBid{
+				Bid:      &bid,


Found incorrect assignment made to Bid. bid variable receives a new value in each iteration of range loop. Assigning the address of bid (&bid) to Bid will result in a pointer that always points to the same memory address with the value of the last iteration. This can lead to unexpected behavior or incorrect results. Refer https://go.dev/play/p/9ZS1f-5h4qS
Consider using an index variable in the seatBids.Bid loop as shown below

for _, seatBid := range response.SeatBid { for i := range seatBids.Bid { ... responseBid := &adapters.TypedBid{ Bid: &seatBids.Bid[i], ... } ... ... } }

Fixed in 960575d

github-actions · 2025-04-14T16:23:20Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 5ea96c2

adagio

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:22:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:29:	MakeRequests	80.0%
github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:54:	MakeBids	93.9%
github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:119:	checkNBRCode	83.3%
github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:138:	getBidType	100.0%
github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:154:	getBidExt	100.0%
total:									(statements)	91.8%

github-actions · 2025-04-14T16:32:53Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 960575d

adagio

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:22:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:29:	MakeRequests	80.0%
github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:54:	MakeBids	94.1%
github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:121:	checkNBRCode	83.3%
github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:140:	getBidType	100.0%
github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:156:	getBidExt	100.0%
total:									(statements)	91.9%

przemkaczmarek · 2025-04-30T08:48:34Z

+endpointCompression: gzip
+maintainer:
+  email: dev@adagio.io
+gvlVendorID: 617


przemkaczmarek · 2025-04-30T09:46:54Z

+endpoint: "https://mp-REGION.4dex.io/pbserver"
+endpointCompression: gzip
+maintainer:
+  email: dev@adagio.io


przemkaczmarek · 2025-04-30T09:58:13Z

+# - For AMER: las => (https://mp-las.4dex.io/pbserver)
+# - For EMEA: ams => (https://mp-ams.4dex.io/pbserver)
+# - For APAC: tyo => (https://mp-tyo.4dex.io/pbserver)
+endpoint: "https://mp-REGION.4dex.io/pbserver"


I have tried all 3 endpoints and always got error:

That's weird, when I make the same request that you do, I got another response:

Our server is expecting our POST requests to have at least a Content-length header set (even if this value is 0).
You can update your command by using :

-H "Content-Length: 0"

or by using --data '' (curl will set by default a content-length by default to 0)

it would become:
curl -i --location -H "Content-Length: 0" --request POST https://mp-ams.4dex.io/pbserver

or

curl -i --location --data '' --request POST https://mp-ams.4dex.io/pbserver

endpoint is reachable:

przemkaczmarek · 2025-04-30T10:02:03Z

@@ -0,0 +1,9 @@
+package openrtb_ext
+
+// ExtImpAdagio defines the contract for bidrequest.imp[i].ext.prebid.bidder for Adagio


Unnecessary comment, please remove

Fixed in c55b565

przemkaczmarek · 2025-04-30T10:12:13Z

+// This file actually intends to test static/bidder-params/pubmatic.json
+//
+// These also validate the format of the external API: request.imp[i].ext.prebid.bidder.pubmatic
+
+// TestValidParams makes sure that the adagio schema accepts all imp.ext fields which we intend to support.


please remove all unnecessary comments

Fixed in c55b565

przemkaczmarek · 2025-04-30T10:14:20Z

+	`{"placement":"some-placement"}`,
+	`{"category":"some-category"}`,
+	`{"pagetype":"some-pagetype"}`,
+	`{"organizationId":"1000"}`,


same case as in line 58, maybe You wanted to use 1000 as int

Indeed that's what I wanted to test. Thanks for noticing it. Fixed in: c55b565

przemkaczmarek · 2025-04-30T11:09:10Z

+	return bidder, nil
+}
+
+func (a *adapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *adapters.ExtraRequestInfo) ([]*adapters.RequestData, []error) {


In the positive scenarios, you have tests for banner, video, and native. I don't see a multi-imp case.
Similarly, in the MakeRequests function, you are not iterating over the Imp array.
Why did you decide to do it this way? Was this intentional?
https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html#makerequests

In the positive scenarios, you have tests for banner, video, and native. I don't see a multi-imp case.

You are right, the multi-imp & multi-format case in now available in commit: e79c185 .

Similarly, in the MakeRequests function, you are not iterating over the Imp array.
Why did you decide to do it this way? Was this intentional?

For now, we want the adapter to act solely as a pass-through, so we don't need to perform any operations on the request (and iterate over the imp array) and this was intentional.

github-actions · 2025-04-30T13:21:44Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, e79c185

adagio

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:22:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:29:	MakeRequests	80.0%
github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:54:	MakeBids	94.1%
github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:121:	checkNBRCode	83.3%
github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:140:	getBidType	100.0%
github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:156:	getBidExt	100.0%
total:									(statements)	91.9%

przemkaczmarek · 2025-05-02T10:18:11Z

+}
+
+func getBidType(bid openrtb2.Bid) (openrtb_ext.BidType, error) {
+	// determinate media type by bid response field mtype


unnecessary comment

Fixed in 476a17c

przemkaczmarek · 2025-05-02T10:20:27Z

+			t.Errorf("Schema allowed unexpected params: %s", invalidParam)
+		}
+	}
+}


TestValidParams

TestInvalidParams

validParams

invalidParams
this is the right order

Fixed in 476a17c

przemkaczmarek · 2025-05-02T10:35:07Z

+	if err := checkNBRCode(bidResponse.NBR); err != nil {
+		return nil, []error{err}
+	}


I think this is unnecessary because in the buildBidResponse function we check the NBR.

Fixed in 00915d8

przemkaczmarek · 2025-05-02T12:15:18Z

@bsardo except endpoint in yaml LGTH. For rest I left comments

github-actions · 2025-05-05T15:49:14Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 00915d8

adagio

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:21:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:28:	MakeRequests	80.0%
github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:52:	MakeBids	93.8%
github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:115:	getBidType	100.0%
github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:130:	getBidExt	100.0%
total:									(statements)	92.6%

bsardo · 2025-06-03T13:52:40Z

+# - For AMER: las => (https://mp-las.4dex.io/pbserver)
+# - For EMEA: ams => (https://mp-ams.4dex.io/pbserver)
+# - For APAC: tyo => (https://mp-tyo.4dex.io/pbserver)
+endpoint: "https://mp-REGION.4dex.io/pbserver"


Hi @GodefroiRoussel. Your adapter looks good. I have just one change that needs to be made. Your adapter needs to work out-of-the-box and since you haven't set endpoint to a working URL, you either need to disable your adapter by adding a disabled: true annotation here similar to what Rubicon and mgidx have done, or you can keep it enabled and set endpoint to a valid URL.

Thanks for the comment @bsardo , we've made the decision to add the disabled: true, you'll find it in 12feaf4

github-actions · 2025-06-03T15:32:42Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 12feaf4

adagio

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:21:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:28:	MakeRequests	80.0%
github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:52:	MakeBids	93.8%
github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:115:	getBidType	100.0%
github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:130:	getBidExt	100.0%
total:									(statements)	92.6%

github-actions · 2025-06-03T15:44:02Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, bb5b3e7

adagio

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:21:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:28:	MakeRequests	80.0%
github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:52:	MakeBids	93.8%
github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:115:	getBidType	100.0%
github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:130:	getBidExt	100.0%
total:									(statements)	92.6%

New Adapter: Adagio

5ea96c2

GodefroiRoussel mentioned this pull request Apr 14, 2025

Update Adagio Documentation prebid/prebid.github.io#5993

Merged

3 tasks

github-actions Bot reviewed Apr 14, 2025

View reviewed changes

fixup! New Adapter: Adagio

960575d

bsardo added the adapter label Apr 22, 2025

bsardo assigned VeronikaSolovei9 and ccorbo Apr 28, 2025

przemkaczmarek reviewed Apr 30, 2025

View reviewed changes

przemkaczmarek self-assigned this Apr 30, 2025

Godefroi Roussel added 2 commits April 30, 2025 15:17

Adagio: Remove unnecessary comments

c55b565

Adagio: add tests for multi imps & multi format

e79c185

przemkaczmarek reviewed May 2, 2025

View reviewed changes

Godefroi Roussel added 2 commits May 5, 2025 17:45

Adagio: fix mr comments

476a17c

Adagio: Remove check NBR code in MakeBids

00915d8

przemkaczmarek previously approved these changes May 6, 2025

View reviewed changes

ccorbo previously approved these changes May 7, 2025

View reviewed changes

bsardo reviewed Jun 3, 2025

View reviewed changes

Adagio: Disable adapter by default

12feaf4

GodefroiRoussel dismissed stale reviews from ccorbo and przemkaczmarek via 12feaf4 June 3, 2025 15:31

fixup! Adagio: Disable adapter by default

bb5b3e7

przemkaczmarek approved these changes Jun 4, 2025

View reviewed changes

ccorbo approved these changes Jun 4, 2025

View reviewed changes

bsardo merged commit 9397524 into prebid:master Jun 5, 2025
6 checks passed

cross-repo-issue-creation Bot mentioned this pull request Jun 5, 2025

Port PR from PBS-Go: New Adapter: Adagio prebid/prebid-server-java#3988

Closed

shunj-nb pushed a commit to ParticleMedia/prebid-server that referenced this pull request Jun 13, 2025

New Adapter: Adagio (prebid#4300)

14ea4e3

prnvgupta pushed a commit to automatad/prebid-server that referenced this pull request Dec 3, 2025

New Adapter: Adagio (prebid#4300)

362108c

		@@ -0,0 +1,9 @@
		package openrtb_ext

		// ExtImpAdagio defines the contract for bidrequest.imp[i].ext.prebid.bidder for Adagio

Conversation

GodefroiRoussel commented Apr 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot Apr 14, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 14, 2025

Code coverage summary

adagio

Uh oh!

github-actions Bot commented Apr 14, 2025

Code coverage summary

adagio

Uh oh!

Choose a reason for hiding this comment

Uh oh!

przemkaczmarek Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GodefroiRoussel Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 30, 2025

Code coverage summary

adagio

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

przemkaczmarek commented May 2, 2025

Uh oh!

github-actions Bot commented May 5, 2025

Code coverage summary

adagio

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 3, 2025

Code coverage summary

adagio

GodefroiRoussel commented Apr 14, 2025 •

edited

Loading

przemkaczmarek Apr 30, 2025 •

edited

Loading

GodefroiRoussel Apr 30, 2025 •

edited

Loading