New Adapter: Nativery

[andreafassina]

Docs PR: prebid/prebid.github.io#6015
prebid/prebid.github.io#6108

[github-actions]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
• Coverage summary encompasses all commits leading up to the latest one, 52b65f4

nativery

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:18:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:30:	MakeRequests		73.3%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:88:	buildNativeryExt	71.4%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:103:	buildRequest		100.0%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:124:	MakeBids		77.4%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:193:	getMediaTypeForBid	80.0%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:206:	convertIntToBoolean	80.0%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:217:	buildBidMeta		100.0%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:233:	splitRequests		81.8%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:276:	getRequestExt		60.0%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:288:	getNativeryExt		71.4%
total:									(statements)		77.3%

[bsardo]

@pm-shriprasad-marathe can you please review?

[ShriprasadM]

@bsardo added my comments

[github-actions]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
• Coverage summary encompasses all commits leading up to the latest one, e28766d

nativery

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:18:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:30:	MakeRequests		83.3%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:88:	buildNativeryExt	85.7%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:103:	buildRequest		100.0%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:123:	MakeBids		87.1%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:192:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:205:	convertIntToBoolean	80.0%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:216:	buildBidMeta		100.0%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:226:	splitRequests		79.2%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:290:	getRequestExt		60.0%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:302:	getNativeryExt		71.4%
total:									(statements)		83.5%

[andreafassina]

@ShriprasadM I think we have addressed all comments from the review. Let me know if further adjustments are required.

[ShriprasadM]

LGTM

[andreafassina]

Hi @ShriprasadM Thanks for your review. @bsardo as this pr has been approved one month ago (before the latest release), can we merge it now? Some of our clients are waiting to start using it. Thanks

[linux019]

Does the endpoint not support gzip?

[andreafassina]

Not at the moment

[przemkaczmarek]

endpoint is not reachable:

[ccorbo]

Confirmed endpoint is reachable, it needs a request body.

[github-actions]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
• Coverage summary encompasses all commits leading up to the latest one, 4862571

nativery

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:18:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:30:	MakeRequests		87.1%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:94:	buildNativeryExt	85.7%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:112:	MakeBids		90.3%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:181:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:194:	buildBidMeta		100.0%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:204:	splitRequests		79.2%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:268:	getRequestExt		60.0%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:280:	getNativeryExt		71.4%
total:									(statements)		85.0%

[github-actions]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
• Coverage summary encompasses all commits leading up to the latest one, 5c56fbc

nativery

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:81:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:93:	MakeRequests		87.1%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:157:	buildNativeryExt	85.7%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:175:	MakeBids		90.3%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:244:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:257:	buildBidMeta		100.0%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:267:	splitRequests		79.2%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:331:	getRequestExt		60.0%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:343:	getNativeryExt		71.4%
total:									(statements)		85.0%

[andreafassina]

@andreafassina sorry for the delay. I was away last week. I'll give this a look and try to get it into the release this week.

@bsardo I was wondering why this PR hasn’t been merged yet — is there anything blocking it? Do you have an approximate ETA?

[andreafassina]

@bsardo @ShriprasadM It’s been two and a half months since this PR was approved, but it still hasn’t been merged. In the meantime, several newer adapters have already been merged. Could you please clarify what’s blocking this one from being merged? We have clients waiting on this, so it would be very helpful to understand the reason for the delay. Thanks in advance for your feedback.

[andreafassina]

It’s been two and a half months since this PR was approved, but it still hasn’t been merged. In the meantime, several newer adapters have already been merged. Could you please clarify what’s blocking this one from being merged?

@bsardo @ccorbo @ShriprasadM @VeronikaSolovei9 @SyntaxNode @przemkaczmarek @guscarreon is there anyone here ?!

[bsardo]

@andreafassina my apologies, this got lost. There's quite a bit going on and a lot of folks have been out over the last several weeks. I will take a quick look at this and try to merge it in this week.

[przemkaczmarek]

delete all unnecesary coments

[andreafassina]

Done

[github-actions]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
• Coverage summary encompasses all commits leading up to the latest one, dd9df0c

nativery

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:38:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:45:	MakeRequests		92.3%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:93:	buildNativeryExt	85.7%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:107:	MakeBids		89.7%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:167:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:180:	buildBidMeta		100.0%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:188:	splitRequests		79.2%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:242:	getRequestExt		60.0%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:254:	getNativeryExt		71.4%
total:									(statements)		85.8%

[github-actions]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
• Coverage summary encompasses all commits leading up to the latest one, fded54c

nativery

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:38:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:45:	MakeRequests		96.2%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:93:	buildNativeryExt	85.7%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:107:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:167:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:180:	buildBidMeta		100.0%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:188:	splitRequests		79.2%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:242:	getRequestExt		80.0%
github.com/prebid/prebid-server/v3/adapters/nativery/nativery.go:254:	getNativeryExt		100.0%
total:									(statements)		92.5%

[andreafassina]

@ccorbo thank you for your review. With this commit we’ve tried to address your requests. Some of them, however, are not feasible for the reasons outlined below.

We’ve added supplemental JSON tests for the error in getNativeryExt (e.g. widgetId of the wrong type) and also extended coverage with additional cases in MakeBids (204 with/without X-Nativery-Error, malformed bid.ext, bad response JSON, etc.).

For the other two error branches (getRequestExt and the first unmarshal in buildNativeryExt), these are not reachable with the supplemental JSON harness: the loader rejects any request.ext or imp.ext that is not a JSON object before it even reaches the adapter, so the errors cannot be triggered that way. Those paths are only hit if Prebid-server were fed invalidly shaped JSON at runtime, which the framework prevents.

So coverage is now above 90%, and all error paths that can be reached via the supplemental tests are exercised. The remaining uncovered lines are structurally unreachable via the harness, not due to missing tests.

Is there anything else we should take care of on our side?

[ccorbo]

@ccorbo thank you for your review. With this commit we’ve tried to address your requests. Some of them, however, are not feasible for the reasons outlined below.

We’ve added supplemental JSON tests for the error in getNativeryExt (e.g. widgetId of the wrong type) and also extended coverage with additional cases in MakeBids (204 with/without X-Nativery-Error, malformed bid.ext, bad response JSON, etc.).

For the other two error branches (getRequestExt and the first unmarshal in buildNativeryExt), these are not reachable with the supplemental JSON harness: the loader rejects any request.ext or imp.ext that is not a JSON object before it even reaches the adapter, so the errors cannot be triggered that way. Those paths are only hit if Prebid-server were fed invalidly shaped JSON at runtime, which the framework prevents.

So coverage is now above 90%, and all error paths that can be reached via the supplemental tests are exercised. The remaining uncovered lines are structurally unreachable via the harness, not due to missing tests.

Is there anything else we should take care of on our side?

Thanks resolving those threads

[ccorbo]

@andreafassina thanks code LGTM, holding off on approving as the endpoint doesnt seem to be reachable

[andreafassina]

@andreafassina thanks code LGTM, holding off on approving as the endpoint doesnt seem to be reachable

thank you. I just saw @przemkaczmarek's comment above. It may look like the endpoint is not reachable, but in reality the request is failing validation. At the moment, the error handling on our side is not very clear and should be improved.
To make the request work, you’ll need to:

• add a User-Agent header that is not flagged as a bot (I know the bot detection could be more accurate, and that’s something we can improve),
• include a request body like the following:

{
    "imp": [
        {
            "ext": {
                "nativery": {
                    "widgetId": "67c854f0067451f100350fe3"
                }
            },
            "id": "206bf70c62410758",
            "banner": {
                "format": [
                    {
                        "w": 300,
                        "h": 600
                    }
                ]
            }
        }
    ],
    "site": {
        "domain": "gustissimo.it",
        "publisher": {
            "domain": "gustissimo.it"
        },
        "page": "https://www.gustissimo.it/ricette/antipasti-pesce/tortino-di-alici.htm",
        "ref": "https://www.gustissimo.it/"
    },
    "id": "29dea7e1-50c4-4760-8528-85cbe41595e7"
}

A working example with curl would be:

curl -i --location --request POST https://hb.nativery.com/openrtb2/auction \
  -H "Content-Type: application/json" \
  -H "User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/140.0.0.0 Safari/537.36" \
  -d '{"imp":[{"ext":{"nativery":{"widgetId":"67c854f0067451f100350fe3"}},"id":"206bf70c62410758","banner":{"format":[{"w":300,"h":600}]}}],"site":{"domain":"gustissimo.it","publisher":{"domain":"gustissimo.it"},"page":"https://www.gustissimo.it/ricette/antipasti-pesce/tortino-di-alici.htm","ref":"https://www.gustissimo.it/"},"id":"29dea7e1-50c4-4760-8528-85cbe41595e7"}'

Even though the validation isn’t perfect at the moment, would this be acceptable for now?

[andreafassina]

@ccorbo @przemkaczmarek thank you for your reviews. @bsardo can you take a look on this PR? Thank you