New Adapter: Tagoras - Vidazoo alias

[saar120]

prebid/prebid.github.io#6130

[github-actions]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
• Coverage summary encompasses all commits leading up to the latest one, 1b265b0

tagoras

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/tagoras/tagoras.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/tagoras/tagoras.go:28:	MakeRequests		77.8%
github.com/prebid/prebid-server/v3/adapters/tagoras/tagoras.go:66:	MakeBids		89.5%
github.com/prebid/prebid-server/v3/adapters/tagoras/tagoras.go:109:	extractCid		71.4%
github.com/prebid/prebid-server/v3/adapters/tagoras/tagoras.go:122:	getMediaTypeForBid	100.0%
total:									(statements)		84.0%

[assa-kariv]

@bsardo could you please update what is the approval status of this adapter?

[github-actions]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
• Coverage summary encompasses all commits leading up to the latest one, a2296d1

tagoras

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/tagoras/tagoras.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/tagoras/tagoras.go:29:	MakeRequests		77.8%
github.com/prebid/prebid-server/v3/adapters/tagoras/tagoras.go:67:	MakeBids		94.7%
github.com/prebid/prebid-server/v3/adapters/tagoras/tagoras.go:108:	extractCid		71.4%
github.com/prebid/prebid-server/v3/adapters/tagoras/tagoras.go:121:	getMediaTypeForBid	100.0%
total:									(statements)		86.0%

[github-actions]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
• Coverage summary encompasses all commits leading up to the latest one, ab6e0e0

tagoras

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/tagoras/tagoras.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/tagoras/tagoras.go:29:	MakeRequests		77.8%
github.com/prebid/prebid-server/v3/adapters/tagoras/tagoras.go:67:	MakeBids		94.7%
github.com/prebid/prebid-server/v3/adapters/tagoras/tagoras.go:108:	extractCid		71.4%
github.com/prebid/prebid-server/v3/adapters/tagoras/tagoras.go:121:	getMediaTypeForBid	100.0%
total:									(statements)		86.0%

[pm-isha-bharti]

Please raise a PR to update the Tagoras documentation and link it in the description.

[saar120]

Please raise a PR to update the Tagoras documentation and link it in the description.

Done

[saar120]

@pm-isha-bharti @ccorbo
Can you please approve?

[bsardo]

@saar120 I noticed that this adapter is basically a copy of kueezrtb. Is this a white label?

[saar120]

Yes, it does.

[bsardo]

@saar120 for white labels like this, please delete all of this code as this leads to a lot of extra maintenance and instead create a single file static/bidder-info/tagoras.yaml with the aliasOf: "kueezrtb" annotation. Your alias will inherit configuration from the base adapter. You can then add any overrides to tagoras.yaml for configuration that differs from the base adapter kueezrtb.
I imagine this should work for you (not tested):

aliasOf: "kueezrtb"
endpoint: "https://exchange.tagoras.io/openrtb/"
maintainer:
  email: "prebid@tagoras.io"
gvlVendorID: 0
userSync:
  iframe:
    url: https://sync.tagoras.io/api/user/html/6819bdc3e6bb44545c55f843?pbs=true&gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&redirect={{.RedirectURL}}&gpp={{.GPP}}&gpp_sid={{.GPPSID}}
    userMacro: ${userId}
openrtb:
    version: 2.6

Agree that the code looks good but given that this is a white label, we should use aliasOf instead of copying another adapter. I'm removing the approval to prevent accidental merging.

[pm-isha-bharti]

Makes sense @bsardo!

[saar120]

@bsardo
Updated @pm-isha-bharti @ccorbo can you please approve?

[pm-isha-bharti]

What does gvlVendorID: 0 indicate?
CC: @bsardo

[saar120]

we don't have gvlid.
Should I remove this field?

[bsardo]

If a GVL vendor ID is not provided it should be set to 0. Since you are creating an alias of an adapter that has a non-zero GVL vendor ID, we should need to explicitly set it to 0 to ensure it overrides. I'll run a test later to confirm this behavior.

[anna-y-perion]

@bsardo , @pm-isha-bharti
is there something else that we need to change here?
Please approve that our change is sufficient and the pr can be approved.

[bsardo]

@saar120 @anna-y-perion I see that Prebid Server deliberately inherits the GVL vendor ID of the adapter it is aliasing whether you explicitly set it to 0 or omit it (https://github.com/prebid/prebid-server/blob/master/config/bidderinfo.go#L342-L344). As such, please remove this line to reduce confusion.

[anna-y-perion]

@bsardo the line was removed

[anna-y-perion]

Hi @ccorbo @pm-isha-bharti
Please approve or let us know what we need to change in order to move forward with ti.

[bsardo]

Hi @ccorbo @pm-isha-bharti Please approve or let us know what we need to change in order to move forward with ti.

See above comment

[anna-y-perion]

@bsardo it fixed. Please approve

[bsardo]

@anna-y-perion @saar120, I can merge this which means your adapter will inherit the GVL ID of the parent. That means if a request referencing Tagoras is received and GDPR applies, the user will need to consent to the parent as part of the GDPR legal basis calculation used to determine if user data needs to be stripped before sending the bid request to Tagoras. If this is ok with you I can merge. Otherwise, you can wait a couple of months until we release 4.0 which will allow overriding a parent GVL ID with a value of zero indicating there is no GVL ID for this alias. See #4463.