Skip to content

Connatix: support GPID #4482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
karimMourra wants to merge 3 commits into from
Closed

Connatix: support GPID #4482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
982c314
supports gpid
karimMourra Aug 12, 2025
218a6de
adds tests
karimMourra Aug 12, 2025
13eeb29
adds test case for missing gpid
karimMourra Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions adapters/connatix/connatix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,7 @@ func buildRequestImp(imp *openrtb2.Imp, ext impExtIncoming, displayManagerVer st
PlacementId: ext.Bidder.PlacementId,
ViewabilityPercentage: ext.Bidder.ViewabilityPercentage,
},
GPID: ext.GPID,
}

var err error
Expand Down
8 changes: 5 additions & 3 deletions adapters/connatix/connatixtest/exemplary/banner-app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@
"ext": {
"bidder": {
"placementId": "some-placement-id"
}
},
"gpid": "test-gpid-banner-app"
}
}
]
Expand Down Expand Up @@ -72,7 +73,8 @@
"ext": {
"connatix": {
"placementId": "some-placement-id"
}
},
"gpid": "test-gpid-banner-app"
}
}
],
Expand Down Expand Up @@ -158,4 +160,4 @@
]
}
]
}
}
6 changes: 4 additions & 2 deletions adapters/connatix/connatixtest/exemplary/banner-web.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@
"ext": {
"bidder": {
"placementId": "some-placement-id"
}
},
"gpid": "test-gpid-banner-web"
}
}
]
Expand Down Expand Up @@ -62,7 +63,8 @@
"ext": {
"connatix": {
"placementId": "some-placement-id"
}
},
"gpid": "test-gpid-banner-web"
}
}
],
Expand Down
6 changes: 4 additions & 2 deletions adapters/connatix/connatixtest/exemplary/video-app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@
"ext": {
"bidder": {
"placementId": "some-placement-id"
}
},
"gpid": "test-gpid-video-app"
}
}
]
Expand Down Expand Up @@ -72,7 +73,8 @@
"ext": {
"connatix": {
"placementId": "some-placement-id"
}
},
"gpid": "test-gpid-video-app"
}
}
],
Expand Down
8 changes: 5 additions & 3 deletions adapters/connatix/connatixtest/exemplary/video-web.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@
"ext": {
"bidder": {
"placementId": "some-placement-id"
}
},
"gpid": "test-gpid-video-web"
}
}
]
Expand Down Expand Up @@ -68,7 +69,8 @@
"ext": {
"connatix": {
"placementId": "some-placement-id"
}
},
"gpid": "test-gpid-video-web"
}
}
],
Expand Down Expand Up @@ -150,4 +152,4 @@
]
}
]
}
}
5 changes: 3 additions & 2 deletions adapters/connatix/connatixtest/supplemental/bad-request-no-ip.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@
"ext": {
"bidder": {
"placementId": "some-placement-id"
}
},
"gpid": "test-gpid"
}
}
]
Expand All @@ -43,4 +44,4 @@
"comparison": "literal"
}
]
}
}
8 changes: 5 additions & 3 deletions adapters/connatix/connatixtest/supplemental/bid-request-eu-user.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@
"bidder": {
"placementId": "some-placement-id",
"viewabilityPercentage": 0.6
}
},
"gpid": "test-gpid"
}
}
]
Expand Down Expand Up @@ -81,7 +82,8 @@
"connatix": {
"placementId": "some-placement-id",
"viewabilityPercentage": 0.6
}
},
"gpid": "test-gpid"
}
}
],
Expand Down Expand Up @@ -173,4 +175,4 @@
]
}
]
}
}
8 changes: 5 additions & 3 deletions adapters/connatix/connatixtest/supplemental/bid-request-no-user.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@
"bidder": {
"placementId": "some-placement-id",
"viewabilityPercentage": 0.6
}
},
"gpid": "test-gpid"
}
}
]
Expand Down Expand Up @@ -78,7 +79,8 @@
"connatix": {
"placementId": "some-placement-id",
"viewabilityPercentage": 0.6
}
},
"gpid": "test-gpid"
}
}
],
Expand Down Expand Up @@ -167,4 +169,4 @@
]
}
]
}
}
8 changes: 5 additions & 3 deletions adapters/connatix/connatixtest/supplemental/bid-request-us-east-user.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@
"bidder": {
"placementId": "some-placement-id",
"viewabilityPercentage": 0.6
}
},
"gpid": "test-gpid"
}
}
]
Expand Down Expand Up @@ -81,7 +82,8 @@
"connatix": {
"placementId": "some-placement-id",
"viewabilityPercentage": 0.6
}
},
"gpid": "test-gpid"
}
}
],
Expand Down Expand Up @@ -173,4 +175,4 @@
]
}
]
}
}
8 changes: 5 additions & 3 deletions adapters/connatix/connatixtest/supplemental/bid-request-us-west-user.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@
"bidder": {
"placementId": "some-placement-id",
"viewabilityPercentage": 0.6
}
},
"gpid": "test-gpid"
}
}
]
Expand Down Expand Up @@ -81,7 +82,8 @@
"connatix": {
"placementId": "some-placement-id",
"viewabilityPercentage": 0.6
}
},
"gpid": "test-gpid"
}
}
],
Expand Down Expand Up @@ -173,4 +175,4 @@
]
}
]
}
}
8 changes: 5 additions & 3 deletions adapters/connatix/connatixtest/supplemental/bid-response-400-status-code.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@
"ext": {
"bidder": {
"placementId": "some-placement-id"
}
},
"gpid": "test-gpid"
}
}
]
Expand Down Expand Up @@ -72,7 +73,8 @@
"ext": {
"connatix": {
"placementId": "some-placement-id"
}
},
"gpid": "test-gpid"
}
}
],
Expand Down Expand Up @@ -110,4 +112,4 @@
"comparison": "literal"
}
]
}
}
8 changes: 5 additions & 3 deletions adapters/connatix/connatixtest/supplemental/bid-response-no-content.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@
"ext": {
"bidder": {
"placementId": "some-placement-id"
}
},
"gpid": "test-gpid"
}
}
]
Expand Down Expand Up @@ -72,7 +73,8 @@
"ext": {
"connatix": {
"placementId": "some-placement-id"
}
},
"gpid": "test-gpid"
}
}
],
Expand Down Expand Up @@ -104,4 +106,4 @@
}
],
"expectedBidResponses": []
}
}
108 changes: 108 additions & 0 deletions adapters/connatix/connatixtest/supplemental/bid-response-no-gpid.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,108 @@
{
"mockBidRequest": {
"id": "some-request-id",
"device": {
"ua": "test-user-agent",
"ip": "123.123.123.123",
"language": "en",
"dnt": 0
},
"tmax": 500,
"user": {
"buyeruid": "some-user"
},
"app": {
"publisher": {
"id": "123456789"
},
"cat": [
"IAB22-1"
],
"bundle": "com.app.awesome",
"name": "Awesome App",
"domain": "awesomeapp.com",
"id": "123456789"
},
"imp": [
{
"id": "some-imp-id",
"tagid": "some-tag-id",
"banner": {
"format":[
{
"w": 320,
"h": 50
}
]
},
"ext": {
"bidder": {
"placementId": "some-placement-id"
}
}
}
]
},
"httpCalls": [
{
"expectedRequest": {
"uri": "http://example.com",
"body": {
"id": "some-request-id",
"device": {
"ua": "test-user-agent",
"ip": "123.123.123.123",
"language": "en",
"dnt": 0
},
"imp": [
{
"id": "some-imp-id",
"tagid": "some-tag-id",
"banner": {
"w": 320,
"h": 50,
"format": [
{
"w": 320,
"h": 50
}
]
},
"ext": {
"connatix": {
"placementId": "some-placement-id"
},
"gpid": ""
}
}
],
"app": {
"id": "123456789",
"name": "Awesome App",
"bundle": "com.app.awesome",
"domain": "awesomeapp.com",
"cat": [
"IAB22-1"
],
"publisher": {
"id": "123456789"
}
},
"user": {
"buyeruid": "some-user"
},
"tmax": 500
},
"impIDs": [
"some-imp-id"
]
},
"mockResponse": {
"status": 204,
"body": null
}
}
],
"expectedBidResponses": []
}
Loading
Loading