Page view ID.#4576
Open
acsbendi wants to merge 3 commits into
Open
Conversation
Code coverage summaryNote:
koblerRefer here for heat map coverage report |
10 tasks
Code coverage summaryNote:
koblerRefer here for heat map coverage report |
Code coverage summaryNote:
koblerRefer here for heat map coverage report |
SyntaxNode
reviewed
May 13, 2026
| GlobalPrivacyControlHeader string | ||
| CurrencyConversions currency.Conversions | ||
| PreferredMediaType openrtb_ext.BidType | ||
| PageViewId string |
Contributor
There was a problem hiding this comment.
Fields in this structure need to be passed this way because they are not present in the request body. The PageViewID is in the request body. I understand it needs to be scoped to each bidder, but why can't the bidder access that information within the request?
Contributor
Author
There was a problem hiding this comment.
So, do you recommend removing all the other page view IDs from the bid request and only keeping the one specific to that adapter?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes enable adaptors to use their page view ID sent by Prebid.js.
See prebid/Prebid.js#14051 for details.