Skip to content

Page view ID.#4576

Open
acsbendi wants to merge 3 commits into
prebid:masterfrom
Essens:master
Open

Page view ID.#4576
acsbendi wants to merge 3 commits into
prebid:masterfrom
Essens:master

Conversation

@acsbendi
Copy link
Copy Markdown
Contributor

@acsbendi acsbendi commented Oct 22, 2025

These changes enable adaptors to use their page view ID sent by Prebid.js.
See prebid/Prebid.js#14051 for details.

@github-actions
Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, a403f9e

kobler

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:28:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:45:	MakeRequests		66.7%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:126:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:157:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:172:	convertImpCurrency	100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:186:	sanitizeRequest		100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:195:	sanitizeDevice		100.0%
total:									(statements)		82.9%

@github-actions
Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 2e3081c

kobler

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:28:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:45:	MakeRequests		66.7%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:126:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:157:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:172:	convertImpCurrency	100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:186:	sanitizeRequest		100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:195:	sanitizeDevice		100.0%
total:									(statements)		82.9%

@github-actions
Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 069b5d6

kobler

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:28:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:45:	MakeRequests		66.7%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:126:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:157:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:172:	convertImpCurrency	100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:186:	sanitizeRequest		100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:195:	sanitizeDevice		100.0%
total:									(statements)		82.9%

Comment thread adapters/bidder.go
GlobalPrivacyControlHeader string
CurrencyConversions currency.Conversions
PreferredMediaType openrtb_ext.BidType
PageViewId string
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fields in this structure need to be passed this way because they are not present in the request body. The PageViewID is in the request body. I understand it needs to be scoped to each bidder, but why can't the bidder access that information within the request?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, do you recommend removing all the other page view IDs from the bid request and only keeping the one specific to that adapter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants