Stroeercore: Use bid.ext as-is from the response#4633
Merged
Conversation
Code coverage summaryNote:
stroeerCoreRefer here for heat map coverage report |
1 task
ccorbo
approved these changes
Jan 6, 2026
|
@pm-isha-bharti Hey Isha, is there any chance that you could review this change from @philipwatson? It's currently blocking one of our publishers, so your help would be highly appreciated here. Thanks a lot in advance 🙏 |
|
Hey @bsardo, could you assign the PR to someone else, so that we can release this and get the additional value for our publisher? Thanks a lot for your help. |
Comment on lines
+105
to
+112
| extMap := map[string]json.RawMessage{} | ||
| if bid.Ext != nil { | ||
| _ = jsonutil.Unmarshal(bid.Ext, &extMap) | ||
| } | ||
| extMap["dsa"] = bid.DSA | ||
| ext, _ := json.Marshal(extMap) | ||
| return ext | ||
| } |
Contributor
There was a problem hiding this comment.
Please add JSON test coverage for this code if not already covered.
Contributor
Author
There was a problem hiding this comment.
I believe this this function is covered by the JSON tests. And the code coverage summary shows 100%. Please let me know if there’s a case you’d like me to add.
PubMatic-OpenWrap
approved these changes
Feb 5, 2026
pm-isha-bharti
approved these changes
Feb 5, 2026
t-sormonte
pushed a commit
to Viously/prebid-server-go
that referenced
this pull request
Mar 20, 2026
anthonyrichir
pushed a commit
to proxistore/prebid-server
that referenced
this pull request
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows us to add to the bid ext without needing to update the adapter, which is especially convenient when adding fields for custom targeting. We intend to move dsa into ext in the near future, but we want to establish the PBS-Go version first.
Equivalent PBS-Java PR: prebid/prebid-server-java#4317