Skip to content

New Bidder: Scalibur#4640

Open
bTimor wants to merge 34 commits into
prebid:masterfrom
scalibur-io:scaliburA
Open

New Bidder: Scalibur#4640
bTimor wants to merge 34 commits into
prebid:masterfrom
scalibur-io:scaliburA

Conversation

@bTimor
Copy link
Copy Markdown

@bTimor bTimor commented Dec 21, 2025

Type of change

  • New bidder adapter

Description

This PR adds the Scalibur bidder adapter to Prebid Server.

Features:

  • Supports Banner and Video media types.
  • Implements User Sync via iframe.
  • Automated tests include standard unit tests and JSON data-driven samples.

Verification:

  • End-to-end user sync flow verified using a private Scalibur sync server.
  • Successfully verified that PBS maps the uids cookie to user.buyeruid in outgoing requests.
  • All tests in adapters/scalibur passed.
  • Root ./validate.sh passed (ignoring unrelated global config/hook test timeouts).

Checklist

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

prebid/prebid.github.io#6381

Comment thread adapters/scalibur/scalibur.go Outdated
Comment thread adapters/scalibur/scalibur.go Outdated
@github-actions
Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, a87ab09

scalibur

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:23:	Builder			75.0%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:35:	MakeRequests		93.0%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:170:	MakeBids		71.1%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:257:	parseScaliburExt	77.8%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:282:	getBidMediaType		40.0%
total:									(statements)		82.7%

@github-actions
Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, c4e7220

scalibur

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:23:	Builder			75.0%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:35:	MakeRequests		86.2%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:186:	MakeBids		71.1%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:273:	parseScaliburExt	77.8%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:298:	getBidMediaType		40.0%
total:									(statements)		79.4%

@github-actions
Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 088c807

scalibur

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:23:	Builder			75.0%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:35:	MakeRequests		86.2%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:186:	MakeBids		71.1%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:273:	parseScaliburExt	77.8%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:298:	getBidMediaType		40.0%
total:									(statements)		79.4%

@github-actions
Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 60a0c74

scalibur

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:23:	Builder			75.0%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:35:	MakeRequests		86.2%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:186:	MakeBids		71.1%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:273:	parseScaliburExt	77.8%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:298:	getBidMediaType		37.5%
total:									(statements)		78.4%

@bTimor
Copy link
Copy Markdown
Author

bTimor commented Dec 23, 2025

I've updated the media type logic to follow the recommended pattern and resolved the bot feedback. Ready for review and workflow approval.

Comment thread adapters/scalibur/scaliburtest/exemplary/success_banner.json
Comment thread adapters/scalibur/scalibur.go Outdated
Comment thread adapters/scalibur/scalibur.go
Comment thread adapters/scalibur/scalibur.go Outdated
Comment thread static/bidder-info/scalibur.yaml
Comment thread static/bidder-params/scalibur.json
Comment thread adapters/scalibur/scalibur.go Outdated
@github-actions
Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 09d4885

scalibur

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:24:	Builder			71.4%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:40:	MakeRequests		84.7%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:196:	MakeBids		89.5%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:284:	parseScaliburExt	77.8%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:309:	getBidMediaType		50.0%
total:									(statements)		82.6%

@bTimor
Copy link
Copy Markdown
Author

bTimor commented Jan 12, 2026

@ccorbo
Updated the PR to address all feedback, including currency conversion, VAST extraction, and test file placement. Ready for another look.

Comment thread adapters/scalibur/scalibur.go Outdated
Comment thread adapters/scalibur/scalibur.go
Comment thread adapters/scalibur/scalibur.go
Comment thread adapters/scalibur/scalibur.go
Comment thread adapters/scalibur/scalibur.go
Comment thread adapters/scalibur/scalibur.go Outdated
Comment thread adapters/scalibur/scalibur.go Outdated
Comment thread static/bidder-info/scalibur.yaml
Comment thread static/bidder-info/scalibur.yaml
Comment thread static/bidder-info/scalibur.yaml
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 4, 2026

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 4aeb4cd

scalibur

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:24:	Builder			75.0%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:36:	MakeRequests		92.9%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:192:	MakeBids		92.1%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:284:	parseScaliburExt	88.9%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:309:	getBidMediaType		100.0%
total:									(statements)		92.4%

@bTimor
Copy link
Copy Markdown
Author

bTimor commented Mar 4, 2026

@bsardo , each time I update the branch with main, it asks me to re-validate the merge.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 5, 2026

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, a02eabe

scalibur

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:24:	Builder			75.0%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:36:	MakeRequests		92.9%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:192:	MakeBids		92.1%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:284:	parseScaliburExt	88.9%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:309:	getBidMediaType		100.0%
total:									(statements)		92.4%

@bTimor
Copy link
Copy Markdown
Author

bTimor commented Mar 8, 2026

@bsardo , should I continue resolving the conflicts myself, or should I just wait for one of you to do it when you try to merge?

@bTimor
Copy link
Copy Markdown
Author

bTimor commented Mar 16, 2026

@bsardo, @ccorbo , @danylo-kazymyrov-teqblaze what should I do next?
Each time the branch is merged with main, it requires a new validate-merge check, which is not triggered automatically. Should I wait for the merge, or keep updating the branch? How should I proceed?
Please advise. I would like to start using the new PBS adapter.

@bTimor
Copy link
Copy Markdown
Author

bTimor commented Mar 24, 2026

@bsardo, @ccorbo , @danylo-kazymyrov-teqblaze what should I do next? Each time the branch is merged with main, it requires a new validate-merge check, which is not triggered automatically. Should I wait for the merge, or keep updating the branch? How should I proceed? Please advise. I would like to start using the new PBS adapter.

Any suggestions?

@danylo-kazymyrov-teqblaze
Copy link
Copy Markdown

@bTimor your branch RN has conflicts. Pls resolve and tag Brian to merge, since we already approved it

@bTimor bTimor dismissed stale reviews from ccorbo and danylo-kazymyrov-teqblaze via 882831c March 25, 2026 12:03
@bTimor
Copy link
Copy Markdown
Author

bTimor commented Mar 25, 2026

Hi @bsardo,
I solved the conflicts again. please help me finish the PR and merge it.
The PR changes approved by 2 reviewers several times already while I didn't had any new code added other then the merges from master.

@github-actions
Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 342e19a

scalibur

Refer here for heat map coverage report

github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:24:	Builder			75.0%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:36:	MakeRequests		92.9%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:192:	MakeBids		92.1%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:284:	parseScaliburExt	88.9%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:309:	getBidMediaType		100.0%
total:									(statements)		92.4%

@bTimor
Copy link
Copy Markdown
Author

bTimor commented Mar 30, 2026

Hi @bsardo, please help me merge the code

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 5, 2026

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 44d7934

scalibur

Refer here for heat map coverage report

github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:24:	Builder			75.0%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:36:	MakeRequests		92.9%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:192:	MakeBids		92.1%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:284:	parseScaliburExt	88.9%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:309:	getBidMediaType		100.0%
total:									(statements)		92.4%

@bTimor
Copy link
Copy Markdown
Author

bTimor commented Apr 5, 2026

@danylo-kazymyrov-teqblaze, all over again. do I do it wrong?

@danylo-kazymyrov-teqblaze
Copy link
Copy Markdown

@bsardo could you merge this Adapter?

@github-actions
Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, ec3eef2

scalibur

Refer here for heat map coverage report

github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:24:	Builder			75.0%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:36:	MakeRequests		92.9%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:192:	MakeBids		92.1%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:284:	parseScaliburExt	88.9%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:309:	getBidMediaType		100.0%
total:									(statements)		92.4%

@bTimor
Copy link
Copy Markdown
Author

bTimor commented Apr 13, 2026

@bsardo Can you please merge the new adapter?

@github-actions
Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, d55fc3e

scalibur

Refer here for heat map coverage report

github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:24:	Builder			75.0%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:36:	MakeRequests		92.9%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:192:	MakeBids		92.1%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:284:	parseScaliburExt	88.9%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:309:	getBidMediaType		100.0%
total:									(statements)		92.4%

@bTimor
Copy link
Copy Markdown
Author

bTimor commented May 10, 2026

@bsardo , @ccorbo , @danylo-kazymyrov-teqblaze, I’ve been trying to merge my branch for a few months now.

Am I doing something wrong? Could you please merge it so I can finally start working with it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants