Skip to content

New Adapter: Adnimation - Vidazoo Alias#4695

Merged
bsardo merged 4 commits into
prebid:masterfrom
Vidazoo:adnimation_adapter
Apr 3, 2026
Merged

New Adapter: Adnimation - Vidazoo Alias#4695
bsardo merged 4 commits into
prebid:masterfrom
Vidazoo:adnimation_adapter

Conversation

@anna-y-perion
Copy link
Copy Markdown
Contributor

@anna-y-perion anna-y-perion commented Feb 23, 2026

Documentation PR:
prebid/prebid.github.io#6446

@anna-y-perion anna-y-perion changed the title Adnimation adapter New adapter - Adnimation Mar 1, 2026
@ChrisHuie
Copy link
Copy Markdown
Contributor

AGENT TESTING PR REVIEW

PR #4695 Review: New Adapter - Adnimation

Author: anna-y-perion | Type: Alias-Only (with userSync) | CI: Clean (all checks passed)


Triage Manifest

Field Value
PR Type alias-only
Files 1 file: static/bidder-info/adnimation.yaml [added]
Bidder affected adnimation (alias of vidazoo)
Skills activated bidder-info-pr-review only
Cross-skill concerns None detected
CI Status Clean (validate 1.23.x, validate 1.24.x, validate-merge, notify — all passed)

File Routing

Skill Files
bidder-info static/bidder-info/adnimation.yaml [added]
bidder-params
adapter-code

Issues Found

WARN: No gvlVendorID declared — GDPR consent will fall back to parent vidazoo's GVL ID 744

The alias file does not declare a gvlVendorID. The parent vidazoo adapter has gvlVendorID: 744 (Vidazoo Ltd). If Adnimation is a separate legal entity with its own IAB GVL registration, they should declare their own vendor ID for accurate GDPR consent enforcement. Without it, PBS will use the parent's GVL ID 744 for consent checks against this alias.

If Adnimation operates under Vidazoo's consent framework and does not have a separate GVL registration, this is acceptable — but should be explicitly confirmed.

File: static/bidder-info/adnimation.yaml


WARN: Missing capabilities field — relying entirely on parent inheritance

The alias file does not declare capabilities. These will be inherited from the parent vidazoo adapter (site: [banner, video], app: [banner, video]). This is valid alias behavior, but worth confirming the intent is to support all parent capabilities, including app context.

File: static/bidder-info/adnimation.yaml


WARN: No PR description or documentation PR linked

The PR body is null — no description was provided. Prebid convention requires a companion documentation PR to prebid.github.io for new adapters/aliases. No such link is present.


INFO: No endpointCompression declared — parent uses gzip

The parent vidazoo adapter declares endpointCompression: gzip. The alias does not declare this field, so it will inherit gzip compression from the parent. This is correct behavior but noted for completeness.


INFO: Same author submitted sister PR #4698 (Apester) — also a vidazoo alias

Both PR #4695 (Adnimation) and PR #4698 (Apester) are from anna-y-perion, both alias vidazoo. The sync URL structure is nearly identical. PR #4698 has an SSL certificate mismatch on its sync domain — this PR's sync domain does not share that issue.


Field-by-Field Verification

1. aliasOf: "vidazoo"

Check Result Evidence
Parent exists PASS static/bidder-info/vidazoo.yaml exists on master
No alias chain PASS vidazoo has no aliasOf field — it is a standalone adapter
White-label compliance PASS Adnimation is a separate organization using vidazoo's bidding infrastructure via alias — correct approach
Endpoint domain differs PASS Alias uses exchange.adnimation.com vs parent's prebidsrvr.cootlogix.com — different domains
Alias completeness PASS maintainer.email is present for partner contact

2. endpoint: "https://exchange.adnimation.com/openrtb/"

Check Result Evidence
URL format PASS Well-formed HTTPS URL
Reachability PASS HTTP 200 on POST, 0.69s response time
SSL/TLS PASS Sectigo cert (CN=*.adnimation.com), valid Feb 10, 2026 – Feb 10, 2027
Domain ownership PASS exchange.adnimation.com — Adnimation is a known publisher monetization platform. Domain matches bidder name
No hardcoded credentials PASS Clean URL
No template macros PASS No {{...}} present

3. maintainer.email: "prebid@adnimation.com"

Check Result Evidence
Email format PASS Valid format user@domain.tld
Domain consistency PASS adnimation.com matches the bidder name and endpoint domain

4. gvlVendorID — NOT PRESENT

Check Result Evidence
Declared WARN No gvlVendorID field in the alias YAML
Parent fallback INFO Parent vidazoo has gvlVendorID: 744 (Vidazoo Ltd) — this will be used for consent checks
Compliance impact WARN If Adnimation has its own GVL entry, it should be declared. If not, parent fallback is acceptable but should be confirmed

5. userSync.iframe

Check Result Evidence
URL format PASS Well-formed HTTPS URL
Reachability PASS HTTP 200, 0.57s response time
SSL/TLS PASS Sectigo cert (CN=*.adnimation.com), valid Feb 10, 2026 – Feb 10, 2027
Macro: {{.GDPR}} PASS Valid macro
Macro: {{.GDPRConsent}} PASS Valid macro
Macro: {{.USPrivacy}} PASS Valid macro
Macro: {{.RedirectURL}} PASS Valid macro
Macro: {{.GPP}} PASS Valid macro
Macro: {{.GPPSID}} PASS Valid macro
userMacro: ${userId} PASS Matches parent vidazoo's userMacro format exactly
Domain consistency PASS sync.adnimation.com uses same wildcard cert as exchange.adnimation.com — consistent domain ownership

6. PR-Level Checks

Check Result Evidence
Documentation PR WARN No documentation PR linked in PR description (description is null/empty)
Duplicate PR check PASS No other open PRs for "adnimation"
CI status PASS All 4 checks passed (validate 1.23.x, validate 1.24.x, validate-merge, notify)

Cross-Field Validation

Rule Result Evidence
Alias consistency PASS No explicit capabilities declared — inherits from parent (valid)
GPP consistency INFO Sync URL includes {{.GPP}} and {{.GPPSID}} macros. Parent vidazoo has openrtb.gpp_supported: true which will be inherited
GDPR compliance WARN No gvlVendorID declared — relies on parent's GVL ID 744 (Vidazoo Ltd). Sync URL does include GDPR macros
Sync domain vs endpoint domain PASS Endpoint uses exchange.adnimation.com, sync uses sync.adnimation.com — same base domain, both share wildcard cert *.adnimation.com

Recommendation: Approve (with minor suggestions)

This is a clean alias-only adapter PR. Both the bidding endpoint and sync URL are live, have valid SSL certificates with matching hostnames, and all CI checks pass. The YAML structure is correct and the sync URL includes all standard privacy macros. Unlike the sister PR #4698 (Apester), there are no SSL issues here.

There are no blocking issues. Suggestions for improvement:

  1. Should clarify: Whether Adnimation has its own IAB GVL vendor ID. If so, declare it in the YAML. If they operate under Vidazoo's GVL registration (vendor 744), this is acceptable as-is but should be explicitly confirmed.
  2. Should fix: Add a PR description linking a companion documentation PR (prebid.github.io) — this is required by Prebid convention for new adapters/aliases.
  3. Be aware: Capabilities (site: [banner, video], app: [banner, video]) and endpointCompression: gzip will be inherited from the parent vidazoo adapter.

Task Completion Summary

Task # Subject Status
1 PR Triage: Classify PR type, route files, check CI Completed
2 Verify adnimation: aliasOf field Completed
3 Verify adnimation: endpoint field Completed
4 Verify adnimation: maintainer.email field Completed
5 Verify adnimation: gvlVendorID (missing) Completed
6 Verify adnimation: userSync.iframe field + macros Completed
7 PR-level: Documentation PR and duplicate check Completed
8 Produce final review summary for PR #4695 Completed

Skills Called

Skill Outcome
pr-triage Executed inline — file categorization (1 file, alias-only), CI check (all 4 passed), cross-skill concerns (none)
bidder-info-pr-review Executed inline — alias validation, endpoint reachability (200, 0.69s), SSL (Sectigo wildcard, valid Feb 2027), GVL (not declared — WARN), userSync (200, valid SSL — PASS)

Code / Commands Executed

Command Purpose Result
curl -X POST https://exchange.adnimation.com/openrtb/ Endpoint reachability HTTP 200, 0.69s
openssl s_client -connect exchange.adnimation.com:443 SSL certificate details Sectigo, CN=*.adnimation.com, valid until Feb 10, 2027
curl https://sync.adnimation.com/api/user/html/... Iframe sync URL reachability HTTP 200, 0.57s
openssl s_client -connect sync.adnimation.com:443 Sync SSL certificate details Sectigo, CN=*.adnimation.com, valid until Feb 10, 2027

WebFetch API Calls

URL Purpose
api.github.com/.../pulls/4695 PR metadata (title, author, labels)
api.github.com/.../pulls/4695/files File list + patches
api.github.com/.../pulls/4695/commits Head SHA for CI check
api.github.com/.../commits/{sha}/check-runs CI status (all 4 passed)
api.github.com/.../pulls/4695/comments Existing review comments (none)
api.github.com/.../issues/4695/comments Existing PR comments (none)
raw.githubusercontent.com/.../vidazoo.yaml Parent adapter YAML for alias validation
api.github.com/search/issues?q=adnimation Duplicate PR check (none found)

aliasOf: "vidazoo"
endpoint: "https://exchange.adnimation.com/openrtb/"
maintainer:
email: "prebid@adnimation.com"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for response

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed:

Image

@@ -0,0 +1,8 @@
aliasOf: "vidazoo"
endpoint: "https://exchange.adnimation.com/openrtb/"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

endpoint is reachable:

Image

email: "prebid@adnimation.com"
userSync:
iframe:
url: https://sync.adnimation.com/api/user/html/697a076271875e8907df35a6?pbs=true&gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&redirect={{.RedirectURL}}&gpp={{.GPP}}&gpp_sid={{.GPPSID}}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works
Image

Copy link
Copy Markdown

@danylo-kazymyrov-teqblaze danylo-kazymyrov-teqblaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown

@danylo-kazymyrov-teqblaze danylo-kazymyrov-teqblaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsardo bsardo changed the title New adapter - Adnimation New Adapter: Adnimation - Vidazoo Alias Mar 31, 2026
@bsardo bsardo merged commit 3061e44 into prebid:master Apr 3, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants