MobileFuse: Update to support OpenRTB MType#4719
Open
tomaszbmf wants to merge 5 commits into
Open
Conversation
Code coverage summaryNote:
mobilefuseRefer here for heat map coverage report |
dtbarne
approved these changes
Mar 16, 2026
Code coverage summaryNote:
mobilefuseRefer here for heat map coverage report |
Contributor
Author
|
Bumping for visibility. This PR migrates the MobileFuse adapter to the standard OpenRTB MType and removes legacy custom logic. All CI checks are passing - could we get a maintainer assigned for review? |
ccorbo
approved these changes
Mar 31, 2026
bsardo
changed the title
Code coverage summaryNote:
mobilefuseRefer here for heat map coverage report |
Contributor
Author
|
Following up on this PR - since we have an approval from @ccorbo and CI is green, could we get a second look to finalize the merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the MobileFuse adapter to utilize the standard OpenRTB
MTypefield for determining bid types, replacing the legacyext.mf.media_typecustom logic.Key Changes:
extJSON to checking the nativebid.MType.ExtMf,BidExt) and logic used solely for parsing the legacy field.getBidTypeto return aBadServerResponseerror ifMTypeis missing or unsupported, rather than defaulting to Banner. Valid bids within the same response are still processed successfully.