Skip to content

Alliance Gravity: update of parameter name #4757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danielbaud wants to merge 1 commit into from
Closed

Alliance Gravity: update of parameter name #4757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion adapters/alliance_gravity/alliance_gravity.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func generateImps(imps []openrtb2.Imp) ([]openrtb2.Imp, error) {
bidderExt.Bidder = json.RawMessage(`{}`)
bidderExt.Prebid = &openrtb_ext.ExtImpPrebid{
StoredRequest: &openrtb_ext.ExtStoredRequest{
ID: allianceGravityExt.SrId,
ID: allianceGravityExt.PlacementId,
},
}

Expand Down
2 changes: 1 addition & 1 deletion adapters/alliance_gravity/alliance_gravitytest/exemplary/simple-audio.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
},
"ext": {
"bidder": {
"srid": "12341234"
"placementId": "12341234"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion adapters/alliance_gravity/alliance_gravitytest/exemplary/simple-banner-inapp.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
},
"ext": {
"bidder": {
"srid": "12341234"
"placementId": "12341234"
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions adapters/alliance_gravity/alliance_gravitytest/exemplary/simple-banner-multiple-bids.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
},
"ext": {
"bidder": {
"srid": "abc"
"placementId": "abc"
}
}
},
Expand All @@ -39,7 +39,7 @@
},
"ext": {
"bidder": {
"srid": "def"
"placementId": "def"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion adapters/alliance_gravity/alliance_gravitytest/exemplary/simple-banner-with-uid.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
},
"ext": {
"bidder": {
"srid": "12341234"
"placementId": "12341234"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion adapters/alliance_gravity/alliance_gravitytest/exemplary/simple-banner.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
"ext": {
"bidder": {
"srid": "12341234"
"placementId": "12341234"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion adapters/alliance_gravity/alliance_gravitytest/exemplary/simple-multi-type-banner.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
},
"ext": {
"bidder": {
"srid": "12341234"
"placementId": "12341234"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion adapters/alliance_gravity/alliance_gravitytest/exemplary/simple-multi-type-video.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
},
"ext": {
"bidder": {
"srid": "12341234"
"placementId": "12341234"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion adapters/alliance_gravity/alliance_gravitytest/exemplary/simple-native.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
},
"ext": {
"bidder": {
"srid": "12341234"
"placementId": "12341234"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion adapters/alliance_gravity/alliance_gravitytest/exemplary/simple-video.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
},
"ext": {
"bidder": {
"srid": "12341234"
"placementId": "12341234"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion adapters/alliance_gravity/alliance_gravitytest/supplemental/204-response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
},
"ext": {
"bidder": {
"srid": "abcdefgh"
"placementId": "abcdefgh"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion adapters/alliance_gravity/alliance_gravitytest/supplemental/400-response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
},
"ext": {
"bidder": {
"srid": "abcdefgh"
"placementId": "abcdefgh"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion adapters/alliance_gravity/alliance_gravitytest/supplemental/500-response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
},
"ext": {
"bidder": {
"srid": "abcdefgh"
"placementId": "abcdefgh"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion adapters/alliance_gravity/alliance_gravitytest/supplemental/empty_seatbid.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
},
"ext": {
"bidder": {
"srid": "abcdefgh"
"placementId": "abcdefgh"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion adapters/alliance_gravity/alliance_gravitytest/supplemental/invalid-bid-response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
"ext": {
"bidder": {
"srid": "1234"
"placementId": "1234"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion adapters/alliance_gravity/alliance_gravitytest/supplemental/wrong-payload.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
"ext": {
"bidder": {
"srid": "1234"
"placementId": "1234"
}
}
}
Expand Down
8 changes: 4 additions & 4 deletions adapters/alliance_gravity/params_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@ func TestInvalidParams(t *testing.T) {
}

var validParams = []string{
`{"srid":"11223344"}`,
`{"srid":"1122334455"}`,
`{"srid":"0"}`,
`{"srid":"11223344","other_params":"hoge"}`,
`{"placementId":"11223344"}`,
`{"placementId":"1122334455"}`,
`{"placementId":"0"}`,
`{"placementId":"11223344","other_params":"hoge"}`,
}

var invalidParams = []string{
Expand Down
2 changes: 1 addition & 1 deletion openrtb_ext/imp_alliance_gravity.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
package openrtb_ext

type ExtImpAllianceGravity struct {
SrId string `json:"srid"`
PlacementId string `json:"placementId"`
}
6 changes: 3 additions & 3 deletions static/bidder-params/alliance_gravity.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@
"description": "A schema which validates params accepted by the Alliance Gravity adapter",
"type": "object",
"properties": {
"srid": {
"placementId": {
"type": "string",
"description": "Stored request ID",
"description": "The placement ID",
"minLength": 1
}
},

"required": ["srid"]
"required": ["placementId"]
}
Loading